| Message ID | 20190923171222.9256-1-krzk@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/panfrost: Reduce the amount of logs on deferred probe | expand |
On 23/09/2019 18:12, Krzysztof Kozlowski wrote: > There is no point to print deferred probe (and its failures to get > resources) as an error. Also there is no need to print regulator errors > twice. > > In case of multiple probe tries this would pollute the dmesg. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Steven Price <steven.price@arm.com> > > --- > > Changes since v1: > 1. Remove second error message from calling panfrost_regulator_init(). > --- > drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c > index 46b0b02e4289..287c6ba314d9 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_device.c > +++ b/drivers/gpu/drm/panfrost/panfrost_device.c > @@ -95,7 +95,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev) > pfdev->regulator = NULL; > if (ret == -ENODEV) > return 0; > - dev_err(pfdev->dev, "failed to get regulator: %d\n", ret); > + if (ret != -EPROBE_DEFER) > + dev_err(pfdev->dev, "failed to get regulator: %d\n", > + ret); > return ret; > } > > @@ -133,10 +135,8 @@ int panfrost_device_init(struct panfrost_device *pfdev) > } > > err = panfrost_regulator_init(pfdev); > - if (err) { > - dev_err(pfdev->dev, "regulator init failed %d\n", err); > + if (err) > goto err_out0; > - } > > err = panfrost_reset_init(pfdev); > if (err) { >
diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c index 46b0b02e4289..287c6ba314d9 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -95,7 +95,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev) pfdev->regulator = NULL; if (ret == -ENODEV) return 0; - dev_err(pfdev->dev, "failed to get regulator: %d\n", ret); + if (ret != -EPROBE_DEFER) + dev_err(pfdev->dev, "failed to get regulator: %d\n", + ret); return ret; } @@ -133,10 +135,8 @@ int panfrost_device_init(struct panfrost_device *pfdev) } err = panfrost_regulator_init(pfdev); - if (err) { - dev_err(pfdev->dev, "regulator init failed %d\n", err); + if (err) goto err_out0; - } err = panfrost_reset_init(pfdev); if (err) {
There is no point to print deferred probe (and its failures to get resources) as an error. Also there is no need to print regulator errors twice. In case of multiple probe tries this would pollute the dmesg. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Changes since v1: 1. Remove second error message from calling panfrost_regulator_init(). --- drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)