From patchwork Wed Sep 25 04:30:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Navid Emamdoost X-Patchwork-Id: 11160119 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0170E1709 for ; Wed, 25 Sep 2019 07:19:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBC7F2082F for ; Wed, 25 Sep 2019 07:19:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBC7F2082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 69ABD8997E; Wed, 25 Sep 2019 07:19:30 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B96E6E832 for ; Wed, 25 Sep 2019 04:30:42 +0000 (UTC) Received: by mail-io1-xd44.google.com with SMTP id r26so10141114ioh.8 for ; Tue, 24 Sep 2019 21:30:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Een0CpGnMmjlIwv6SGvcNYXFPmeEyRahY8Cx/ZLw6Cs=; b=OTfEPup+VvBKxOsc6iFmaH7teCyw6zGfCRMeJ4/oqg9dr2v8pxLpDSWJdIl3EIJruZ FnPvlAgiG1T1n7iDqykMAohdjflQJMH2yIxh+OGKMZt9SG0bxzAXrSJAV9VU7mV7DysX mQeovAfX0sk93teLLQ1SqeXjMEdkghEWuOyZYrwxx8ur4Ckim5PZvHxCT4nblznKEK7H qd5aZPO4NJr/nLdGow50AQIBbSCFcfFAcz6AMC/aFMuPpgMlu1z316vg5ovtobamjMd7 IYXqrUnex2dXdjIJxoEwAiNoIE5Utwe7CKqZvQOEdLUgMwDNcyRmqrVHOlVo1sVva/VN 8arg== X-Gm-Message-State: APjAAAWoDKzIRj06mNB/8ifK5Dx+T6qSWk/BUoz587amaWe4Q6x6CocM Yq8jzH4Bhw/13Gz3f/rMjWUHSZsPtww= X-Google-Smtp-Source: APXvYqzEomJ2P1aN8yp1bKMYaBxSHch+LNln2o811DhB87lddkLKVluZBUQPiHMnHUBd6N5Ipj+Bdw== X-Received: by 2002:a5d:8f92:: with SMTP id l18mr4766636iol.143.1569385841381; Tue, 24 Sep 2019 21:30:41 -0700 (PDT) Received: from cs-dulles.cs.umn.edu (cs-dulles.cs.umn.edu. [128.101.35.54]) by smtp.googlemail.com with ESMTPSA id o16sm42508ilf.80.2019.09.24.21.30.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2019 21:30:40 -0700 (PDT) From: Navid Emamdoost To: Subject: [PATCH] drm/komeda: prevent memory leak in komeda_wb_connector_add Date: Tue, 24 Sep 2019 23:30:30 -0500 Message-Id: <20190925043031.32308-1-navid.emamdoost@gmail.com> X-Mailer: git-send-email 2.17.1 X-Mailman-Approved-At: Wed, 25 Sep 2019 07:19:29 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Een0CpGnMmjlIwv6SGvcNYXFPmeEyRahY8Cx/ZLw6Cs=; b=DLSdyfZ7jMpKvSBsDSe7mOpAysxnrw6UY6qtMxOjDFe9vauIc1eUtuQkHTRe9saurj sUUAYFB/R+ae8fTscfHi6/muabc8G1gFEydiAZM8qAqKnIxbvOuYB4zWpWzmt9dQiYCE rHDv6db0OavUV30UpKkXkowxibuS6fjz5+1ud3L9CgQ0m2xMRGx8ql7XaNFC3ywAWJxV MjsC0INc0XpGuC+YgC328Pz2Y5IssNWwN2PemFjnEHftVZXdB0E7Z7Bh2Qoc6d/CVvEM HtPD+XfgI0bE4VSspBvxxDJiFwSp1CbmHP0WelXA5DBSZjSwCHfGBS/rIRcjOaSnlrHm TFiA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , kjlu@umn.edu, Liviu Dudau , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, emamd001@umn.edu, "James \(Qian\) Wang" , smccaman@umn.edu, Navid Emamdoost MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In komeda_wb_connector_add if drm_writeback_connector_init fails the allocated memory for kwb_conn should be released. Signed-off-by: Navid Emamdoost Reviewed-by: James Qian Wang (Arm Technology China) --- drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c index 2851cac94d86..75133f967fdb 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c @@ -166,8 +166,10 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms, &komeda_wb_encoder_helper_funcs, formats, n_formats); komeda_put_fourcc_list(formats); - if (err) + if (err) { + kfree(kwb_conn); return err; + } drm_connector_helper_add(&wb_conn->base, &komeda_wb_conn_helper_funcs);