Message ID | 20191015143509.1104985-3-thierry.reding@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | drm/dp: Move drm_dp_link helpers to Tegra DRM | expand |
Reviewed-by: Lyude Paul <lyude@redhat.com> On Tue, 2019-10-15 at 16:34 +0200, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > It's idiomatic to check the return value of a function call immediately > after the function call, without any blank lines in between, to make it > more obvious that the two lines belong together. > > v2: fix outdated commit message (Philipp Zabel) > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/gpu/drm/drm_dp_helper.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_dp_helper.c > b/drivers/gpu/drm/drm_dp_helper.c > index f373798d82f6..8f2d7c4850ca 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -220,7 +220,6 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 > request, > } > > ret = aux->transfer(aux, &msg); > - > if (ret >= 0) { > native_reply = msg.reply & DP_AUX_NATIVE_REPLY_MASK; > if (native_reply == DP_AUX_NATIVE_REPLY_ACK) {
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index f373798d82f6..8f2d7c4850ca 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b/drivers/gpu/drm/drm_dp_helper.c @@ -220,7 +220,6 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request, } ret = aux->transfer(aux, &msg); - if (ret >= 0) { native_reply = msg.reply & DP_AUX_NATIVE_REPLY_MASK; if (native_reply == DP_AUX_NATIVE_REPLY_ACK) {