| Message ID | 20191017110846.21769-1-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: include <drm/drm_cache.h> for 'drm_need_swiotlb' | expand |
On Thu, Oct 17, 2019 at 12:08:46PM +0100, Ben Dooks (Codethink) wrote: > The drm_need_swiotlb is declared in <drm/drm_cache.h> > which should be included in drivers/gpu/drm/drm_memory.c > to silence the following warning: > > drivers/gpu/drm/drm_memory.c:159:6: warning: symbol 'drm_need_swiotlb' was not declared. Should it be static? IIRC I silenced that already, so you're probably working on some old tree. For the latest stuff use: git://anongit.freedesktop.org/drm-tip drm-tip > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Maxime Ripard <mripard@kernel.org> > Cc: Sean Paul <sean@poorly.run> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: dri-devel@lists.freedesktop.org > --- > drivers/gpu/drm/drm_memory.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c > index 0bec6dbb0142..2d8615baeadc 100644 > --- a/drivers/gpu/drm/drm_memory.c > +++ b/drivers/gpu/drm/drm_memory.c > @@ -41,6 +41,7 @@ > > #include <drm/drm_agpsupport.h> > #include <drm/drm_device.h> > +#include <drm/drm_cache.h> > > #include "drm_legacy.h" > > -- > 2.23.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c index 0bec6dbb0142..2d8615baeadc 100644 --- a/drivers/gpu/drm/drm_memory.c +++ b/drivers/gpu/drm/drm_memory.c @@ -41,6 +41,7 @@ #include <drm/drm_agpsupport.h> #include <drm/drm_device.h> +#include <drm/drm_cache.h> #include "drm_legacy.h"
The drm_need_swiotlb is declared in <drm/drm_cache.h> which should be included in drivers/gpu/drm/drm_memory.c to silence the following warning: drivers/gpu/drm/drm_memory.c:159:6: warning: symbol 'drm_need_swiotlb' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <mripard@kernel.org> Cc: Sean Paul <sean@poorly.run> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/drm_memory.c | 1 + 1 file changed, 1 insertion(+)