Message ID | 20191019073430.22093-1-wambui@karuga.xyz (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | drm/amd/amdgpu: correct length misspelling | expand |
On 2019-10-19 3:34 a.m., Wambui Karuga wrote: > Correct the "_LENTH" mispelling in the AMDGPU_MAX_TIMEOUT_PARAM_LENGTH > constant. > > Signed-off-by: Wambui Karuga <wambui@karuga.xyz> This patch would be better sent in a patch set with the "make undeclared variables static" patch. You can do that by providing a range to "git format-patch". I usually call git format-patch with the -o parameter to put all my patches in a directory. Then I can send it with "git send-email *" in that directory. Reviewed-by: Harry Wentland <harry.wentland@amd.com> This won't apply cleanly without "make undeclared variables static". Please see my comments on that patch and send a v2 for this one. Harry > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > index c5b3c0c9193b..aaab37833659 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > @@ -86,7 +86,7 @@ > #define KMS_DRIVER_MINOR 34 > #define KMS_DRIVER_PATCHLEVEL 0 > > -#define AMDGPU_MAX_TIMEOUT_PARAM_LENTH 256 > +#define AMDGPU_MAX_TIMEOUT_PARAM_LENGTH 256 > > int amdgpu_vram_limit = 0; > int amdgpu_vis_vram_limit = 0; > @@ -100,7 +100,7 @@ int amdgpu_disp_priority = 0; > int amdgpu_hw_i2c = 0; > int amdgpu_pcie_gen2 = -1; > int amdgpu_msi = -1; > -static char amdgpu_lockup_timeout[AMDGPU_MAX_TIMEOUT_PARAM_LENTH]; > +static char amdgpu_lockup_timeout[AMDGPU_MAX_TIMEOUT_PARAM_LENGTH]; > int amdgpu_dpm = -1; > int amdgpu_fw_load_type = -1; > int amdgpu_aspm = -1; > @@ -1327,9 +1327,9 @@ int amdgpu_device_get_job_timeout_settings(struct amdgpu_device *adev) > adev->sdma_timeout = adev->video_timeout = adev->gfx_timeout; > adev->compute_timeout = MAX_SCHEDULE_TIMEOUT; > > - if (strnlen(input, AMDGPU_MAX_TIMEOUT_PARAM_LENTH)) { > + if (strnlen(input, AMDGPU_MAX_TIMEOUT_PARAM_LENGTH)) { > while ((timeout_setting = strsep(&input, ",")) && > - strnlen(timeout_setting, AMDGPU_MAX_TIMEOUT_PARAM_LENTH)) { > + strnlen(timeout_setting, AMDGPU_MAX_TIMEOUT_PARAM_LENGTH)) { > ret = kstrtol(timeout_setting, 0, &timeout); > if (ret) > return ret; >
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index c5b3c0c9193b..aaab37833659 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c @@ -86,7 +86,7 @@ #define KMS_DRIVER_MINOR 34 #define KMS_DRIVER_PATCHLEVEL 0 -#define AMDGPU_MAX_TIMEOUT_PARAM_LENTH 256 +#define AMDGPU_MAX_TIMEOUT_PARAM_LENGTH 256 int amdgpu_vram_limit = 0; int amdgpu_vis_vram_limit = 0; @@ -100,7 +100,7 @@ int amdgpu_disp_priority = 0; int amdgpu_hw_i2c = 0; int amdgpu_pcie_gen2 = -1; int amdgpu_msi = -1; -static char amdgpu_lockup_timeout[AMDGPU_MAX_TIMEOUT_PARAM_LENTH]; +static char amdgpu_lockup_timeout[AMDGPU_MAX_TIMEOUT_PARAM_LENGTH]; int amdgpu_dpm = -1; int amdgpu_fw_load_type = -1; int amdgpu_aspm = -1; @@ -1327,9 +1327,9 @@ int amdgpu_device_get_job_timeout_settings(struct amdgpu_device *adev) adev->sdma_timeout = adev->video_timeout = adev->gfx_timeout; adev->compute_timeout = MAX_SCHEDULE_TIMEOUT; - if (strnlen(input, AMDGPU_MAX_TIMEOUT_PARAM_LENTH)) { + if (strnlen(input, AMDGPU_MAX_TIMEOUT_PARAM_LENGTH)) { while ((timeout_setting = strsep(&input, ",")) && - strnlen(timeout_setting, AMDGPU_MAX_TIMEOUT_PARAM_LENTH)) { + strnlen(timeout_setting, AMDGPU_MAX_TIMEOUT_PARAM_LENGTH)) { ret = kstrtol(timeout_setting, 0, &timeout); if (ret) return ret;
Correct the "_LENTH" mispelling in the AMDGPU_MAX_TIMEOUT_PARAM_LENGTH constant. Signed-off-by: Wambui Karuga <wambui@karuga.xyz> --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)