| Message ID | 20191023154512.9762-18-boris.brezillon@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Add support for bus-format negotiation | expand |
On Wed, Oct 23, 2019 at 05:45:08PM +0200, Boris Brezillon wrote: > Add the data-mapping property to describe the output bus format and > the bus-width property to describe the input bus format. > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > Changes in v3: > * New patch > --- > .../bindings/display/bridge/lvds-transmitter.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > index 60091db5dfa5..7b43b6f20279 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > @@ -36,6 +36,19 @@ graph bindings specified in Documentation/devicetree/bindings/graph.txt. > - Video port 0 for parallel input > - Video port 1 for LVDS output > > +Optional port 0 node properties: > + > +- bus-width: number of data lines use to transmit the RGB data. > + Can be 18 or 24. > + > +Optional port 1 node properties: > + > +- data-mapping: see Documentation/devicetree/bindings/display/panel/lvds.yaml > + for more details about this LVDS data-mapping property. > + Supported values: > + "jeida-18" > + "jeida-24" > + "vesa-24" This is already defined to be a panel property. Do we need it at both ends? Also, why duplicate all the supported values. Rob
On Fri, 25 Oct 2019 14:57:11 -0500 Rob Herring <robh@kernel.org> wrote: > On Wed, Oct 23, 2019 at 05:45:08PM +0200, Boris Brezillon wrote: > > Add the data-mapping property to describe the output bus format and > > the bus-width property to describe the input bus format. > > > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > > --- > > Changes in v3: > > * New patch > > --- > > .../bindings/display/bridge/lvds-transmitter.txt | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > > index 60091db5dfa5..7b43b6f20279 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > > @@ -36,6 +36,19 @@ graph bindings specified in Documentation/devicetree/bindings/graph.txt. > > - Video port 0 for parallel input > > - Video port 1 for LVDS output > > > > +Optional port 0 node properties: > > + > > +- bus-width: number of data lines use to transmit the RGB data. > > + Can be 18 or 24. > > + > > +Optional port 1 node properties: > > + > > +- data-mapping: see Documentation/devicetree/bindings/display/panel/lvds.yaml > > + for more details about this LVDS data-mapping property. > > + Supported values: > > + "jeida-18" > > + "jeida-24" > > + "vesa-24" > > This is already defined to be a panel property. Do we need it at both > ends? That's a valid point. I'll patch the panel-simple driver to takes this DT prop into account.
Hi Boris, Thank you for the patch. On Wed, Oct 23, 2019 at 05:45:08PM +0200, Boris Brezillon wrote: > Add the data-mapping property to describe the output bus format and > the bus-width property to describe the input bus format. > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > Changes in v3: > * New patch > --- > .../bindings/display/bridge/lvds-transmitter.txt | 13 +++++++++++++ Please note that lvds-transmitter has been renamed to lvds-codec and converted to YAML as part of a pull request I've recently sent ([1]). This patch will thus need to be rebased. [1] https://patchwork.freedesktop.org/patch/342754/ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > index 60091db5dfa5..7b43b6f20279 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > @@ -36,6 +36,19 @@ graph bindings specified in Documentation/devicetree/bindings/graph.txt. > - Video port 0 for parallel input > - Video port 1 for LVDS output > > +Optional port 0 node properties: > + > +- bus-width: number of data lines use to transmit the RGB data. > + Can be 18 or 24. > + > +Optional port 1 node properties: > + > +- data-mapping: see Documentation/devicetree/bindings/display/panel/lvds.yaml > + for more details about this LVDS data-mapping property. > + Supported values: > + "jeida-18" > + "jeida-24" > + "vesa-24" > > Example > -------
On Mon, 2 Dec 2019 19:11:40 +0200 Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > Hi Boris, > > Thank you for the patch. > > On Wed, Oct 23, 2019 at 05:45:08PM +0200, Boris Brezillon wrote: > > Add the data-mapping property to describe the output bus format and > > the bus-width property to describe the input bus format. > > > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > > --- > > Changes in v3: > > * New patch > > --- > > .../bindings/display/bridge/lvds-transmitter.txt | 13 +++++++++++++ > > Please note that lvds-transmitter has been renamed to lvds-codec and > converted to YAML as part of a pull request I've recently sent ([1]). > This patch will thus need to be rebased. Let me know when it's been merged, I'll ask for a drm-next -> drm-misc-next backmerge. > > [1] https://patchwork.freedesktop.org/patch/342754/ > > > 1 file changed, 13 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > > index 60091db5dfa5..7b43b6f20279 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > > @@ -36,6 +36,19 @@ graph bindings specified in Documentation/devicetree/bindings/graph.txt. > > - Video port 0 for parallel input > > - Video port 1 for LVDS output > > > > +Optional port 0 node properties: > > + > > +- bus-width: number of data lines use to transmit the RGB data. > > + Can be 18 or 24. > > + > > +Optional port 1 node properties: > > + > > +- data-mapping: see Documentation/devicetree/bindings/display/panel/lvds.yaml > > + for more details about this LVDS data-mapping property. > > + Supported values: > > + "jeida-18" > > + "jeida-24" > > + "vesa-24" > > > > Example > > ------- >
Hi Boris, On Tue, Dec 03, 2019 at 01:38:43PM +0100, Boris Brezillon wrote: > On Mon, 2 Dec 2019 19:11:40 +0200 Laurent Pinchart wrote: > > On Wed, Oct 23, 2019 at 05:45:08PM +0200, Boris Brezillon wrote: > > > Add the data-mapping property to describe the output bus format and > > > the bus-width property to describe the input bus format. > > > > > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > > > --- > > > Changes in v3: > > > * New patch > > > --- > > > .../bindings/display/bridge/lvds-transmitter.txt | 13 +++++++++++++ > > > > Please note that lvds-transmitter has been renamed to lvds-codec and > > converted to YAML as part of a pull request I've recently sent ([1]). > > This patch will thus need to be rebased. > > Let me know when it's been merged, I'll ask for a drm-next -> > drm-misc-next backmerge. I expect Dave to merge it when the merge window will close. > > [1] https://patchwork.freedesktop.org/patch/342754/ > > > > > 1 file changed, 13 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > > > index 60091db5dfa5..7b43b6f20279 100644 > > > --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > > > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > > > @@ -36,6 +36,19 @@ graph bindings specified in Documentation/devicetree/bindings/graph.txt. > > > - Video port 0 for parallel input > > > - Video port 1 for LVDS output > > > > > > +Optional port 0 node properties: > > > + > > > +- bus-width: number of data lines use to transmit the RGB data. > > > + Can be 18 or 24. > > > + > > > +Optional port 1 node properties: > > > + > > > +- data-mapping: see Documentation/devicetree/bindings/display/panel/lvds.yaml > > > + for more details about this LVDS data-mapping property. > > > + Supported values: > > > + "jeida-18" > > > + "jeida-24" > > > + "vesa-24" > > > > > > Example > > > -------
diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt index 60091db5dfa5..7b43b6f20279 100644 --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt @@ -36,6 +36,19 @@ graph bindings specified in Documentation/devicetree/bindings/graph.txt. - Video port 0 for parallel input - Video port 1 for LVDS output +Optional port 0 node properties: + +- bus-width: number of data lines use to transmit the RGB data. + Can be 18 or 24. + +Optional port 1 node properties: + +- data-mapping: see Documentation/devicetree/bindings/display/panel/lvds.yaml + for more details about this LVDS data-mapping property. + Supported values: + "jeida-18" + "jeida-24" + "vesa-24" Example -------
Add the data-mapping property to describe the output bus format and the bus-width property to describe the input bus format. Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> --- Changes in v3: * New patch --- .../bindings/display/bridge/lvds-transmitter.txt | 13 +++++++++++++ 1 file changed, 13 insertions(+)