| Message ID | 20191028133621.21400-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On 2019/10/28 22:06, Alex Deucher wrote: > On Mon, Oct 28, 2019 at 9:37 AM YueHaibing <yuehaibing@huawei.com> wrote: >> >> Fix sparse warnings: >> >> drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c:2050:5: >> warning: symbol 'arcturus_i2c_eeprom_control_init' was not declared. Should it be static? >> drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c:2068:6: >> warning: symbol 'arcturus_i2c_eeprom_control_fini' was not declared. Should it be static? >> >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Applied. Thanks. Is there more to this series? I don't see patches 1 or 2. No, only this one. I forget to change the patch title. Sorry for confusion. > > Alex > >> --- >> drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c >> index d48a49d..3099ac2 100644 >> --- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c >> +++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c >> @@ -2047,7 +2047,7 @@ static const struct i2c_algorithm arcturus_i2c_eeprom_i2c_algo = { >> .functionality = arcturus_i2c_eeprom_i2c_func, >> }; >> >> -int arcturus_i2c_eeprom_control_init(struct i2c_adapter *control) >> +static int arcturus_i2c_eeprom_control_init(struct i2c_adapter *control) >> { >> struct amdgpu_device *adev = to_amdgpu_device(control); >> int res; >> @@ -2065,7 +2065,7 @@ int arcturus_i2c_eeprom_control_init(struct i2c_adapter *control) >> return res; >> } >> >> -void arcturus_i2c_eeprom_control_fini(struct i2c_adapter *control) >> +static void arcturus_i2c_eeprom_control_fini(struct i2c_adapter *control) >> { >> i2c_del_adapter(control); >> } >> -- >> 2.7.4 >> >> >> _______________________________________________ >> amd-gfx mailing list >> amd-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > > . >
diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c index d48a49d..3099ac2 100644 --- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c @@ -2047,7 +2047,7 @@ static const struct i2c_algorithm arcturus_i2c_eeprom_i2c_algo = { .functionality = arcturus_i2c_eeprom_i2c_func, }; -int arcturus_i2c_eeprom_control_init(struct i2c_adapter *control) +static int arcturus_i2c_eeprom_control_init(struct i2c_adapter *control) { struct amdgpu_device *adev = to_amdgpu_device(control); int res; @@ -2065,7 +2065,7 @@ int arcturus_i2c_eeprom_control_init(struct i2c_adapter *control) return res; } -void arcturus_i2c_eeprom_control_fini(struct i2c_adapter *control) +static void arcturus_i2c_eeprom_control_fini(struct i2c_adapter *control) { i2c_del_adapter(control); }
Fix sparse warnings: drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c:2050:5: warning: symbol 'arcturus_i2c_eeprom_control_init' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c:2068:6: warning: symbol 'arcturus_i2c_eeprom_control_fini' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)