| Message ID | 20191109154921.223093-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amd/display: remove duplicated comparison expression | expand |
On 2019-11-09 10:49 a.m., Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > There is comparison expression that is duplicated and hence one > of the expressions can be removed. Remove it. > > Addresses-Coverity: ("Same on both sides") > Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Thanks! Nicholas Kazlauskas > --- > drivers/gpu/drm/amd/display/dc/core/dc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c > index 1fdba13b3d0f..1fa255e077d0 100644 > --- a/drivers/gpu/drm/amd/display/dc/core/dc.c > +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c > @@ -1491,7 +1491,6 @@ static enum surface_update_type get_plane_info_update_type(const struct dc_surfa > } > > if (u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch > - || u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch > || u->plane_info->plane_size.chroma_pitch != u->surface->plane_size.chroma_pitch) { > update_flags->bits.plane_size_change = 1; > elevate_update_type(&update_type, UPDATE_TYPE_MED); >
Applied. Thanks! Alex On Mon, Nov 11, 2019 at 8:38 AM Kazlauskas, Nicholas <nicholas.kazlauskas@amd.com> wrote: > > On 2019-11-09 10:49 a.m., Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > There is comparison expression that is duplicated and hence one > > of the expressions can be removed. Remove it. > > > > Addresses-Coverity: ("Same on both sides") > > Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> > > Thanks! > > Nicholas Kazlauskas > > > --- > > drivers/gpu/drm/amd/display/dc/core/dc.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c > > index 1fdba13b3d0f..1fa255e077d0 100644 > > --- a/drivers/gpu/drm/amd/display/dc/core/dc.c > > +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c > > @@ -1491,7 +1491,6 @@ static enum surface_update_type get_plane_info_update_type(const struct dc_surfa > > } > > > > if (u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch > > - || u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch > > || u->plane_info->plane_size.chroma_pitch != u->surface->plane_size.chroma_pitch) { > > update_flags->bits.plane_size_change = 1; > > elevate_update_type(&update_type, UPDATE_TYPE_MED); > > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index 1fdba13b3d0f..1fa255e077d0 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c @@ -1491,7 +1491,6 @@ static enum surface_update_type get_plane_info_update_type(const struct dc_surfa } if (u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch - || u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch || u->plane_info->plane_size.chroma_pitch != u->surface->plane_size.chroma_pitch) { update_flags->bits.plane_size_change = 1; elevate_update_type(&update_type, UPDATE_TYPE_MED);