From patchwork Mon Nov 18 11:41:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chuhong Yuan X-Patchwork-Id: 11251057 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 30921138C for ; Tue, 19 Nov 2019 08:05:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 130CB222EF for ; Tue, 19 Nov 2019 08:05:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 130CB222EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A7BBB6EBC5; Tue, 19 Nov 2019 08:04:37 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E69D6E48F for ; Mon, 18 Nov 2019 11:41:59 +0000 (UTC) Received: by mail-pg1-x543.google.com with SMTP id e6so1551745pgi.11 for ; Mon, 18 Nov 2019 03:41:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GUSVLZmMqCMWMeD0FT4xlPzHbtQaXySLAxO0s7N20fw=; b=o5K+/cyeXV4VBB0L8WQv6qlIJbdPhuUeqGGSo2NBUXW0Xq2p05kUEypt0xjIXcMezw FHKp+TDDDktU6UQVp7u0dbZkNplP9fvkDgAtsTpLQKMRn2SuTNtWPsJc5q1HteSL289S j0UBdnFgeSTtXv0mCevJxMrmu7M+Q/X6/1HeGeAnWCyJveA6bdscbuHTctKDYN4J1bmF Bm5Iba2/RJZLsM76xTSKdieytrJuHsonCH8K304nBWHNSFVkHUv3YNh6GPwBNV3Ad85w RukJbtlrH7w2xNsNF7C4tf3yNiDf0S1S0VmFKR1yL21EbcwFAvZUXAl8ndsJszU6jhG6 Wuxw== X-Gm-Message-State: APjAAAUMZy0tcex9Z4ojizOr937kUCjBnlb5T6TtccSzyN8kC5Ox7T0Z 6kBCQ6uDnk9lszRa4LHchkc= X-Google-Smtp-Source: APXvYqwlZhctfGUcf61eKwA95+64A55BOSGDXtVe6j8GQMt1TABUbYCgPWwT7eZpn3YAxZAoBaB9dw== X-Received: by 2002:aa7:80d2:: with SMTP id a18mr15473101pfn.29.1574077319270; Mon, 18 Nov 2019 03:41:59 -0800 (PST) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id m19sm19455324pgh.31.2019.11.18.03.41.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 03:41:58 -0800 (PST) From: Chuhong Yuan To: Subject: [PATCH] video: ssd1307fb: add the missed regulator_disable Date: Mon, 18 Nov 2019 19:41:50 +0800 Message-Id: <20191118114150.25724-1-hslester96@gmail.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 19 Nov 2019 08:04:07 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GUSVLZmMqCMWMeD0FT4xlPzHbtQaXySLAxO0s7N20fw=; b=OyaN94NXMpCVElZ8Jw1WSv1yyO+jM2NeUo+yFOKhRx4WUNFccidxt6IWuwEiFy84z+ tNQg5QGqeNbQPOTBhrRHcHxbWgMkT157Ebb4Dz1jWP/askkCcH8pofzUjkl8IDLGkhC0 Wr9nznlGpUgn+s3PUWzUS0mwNmyJPLvXaYhWsRrOuZixx63Bn7APNEKGoqcr7pV9LImk QU++7ig0TwtFloemfAXCPH9Pu8q1dVP8nAillJt4c6ATNHv54emIlGz6FX0EuTXP2xWJ ZXUK9J8VmhbowEhKNbgtceawRPuCkvQXlDFiRTo6I7mm+WemE1CBJ8P4uboM+bPfoO1f Ln8A== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Chuhong Yuan , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The driver forgets to disable the regulator in remove like what is done in probe failure. Add the missed call to fix it. Signed-off-by: Chuhong Yuan Tested-by: Michal Vokáč --- drivers/video/fbdev/ssd1307fb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c index 78ca7ffc40c2..819fbee18dda 100644 --- a/drivers/video/fbdev/ssd1307fb.c +++ b/drivers/video/fbdev/ssd1307fb.c @@ -791,6 +791,8 @@ static int ssd1307fb_remove(struct i2c_client *client) pwm_disable(par->pwm); pwm_put(par->pwm); } + if (par->vbat_reg) + regulator_disable(par->vbat_reg); fb_deferred_io_cleanup(info); __free_pages(__va(info->fix.smem_start), get_order(info->fix.smem_len)); framebuffer_release(info);