diff mbox series

drm: radeon: replace 0 with NULL

Message ID 20191126003514.133692-1-jbi.octave@gmail.com (mailing list archive)
State New, archived
Headers show
Series drm: radeon: replace 0 with NULL | expand

Commit Message

Jules Irenge Nov. 26, 2019, 12:35 a.m. UTC
Replace 0 with NULL to fix sparse tool  warning
 warning: Using plain integer as NULL pointer

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/gpu/drm/radeon/radeon_audio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christian König Nov. 26, 2019, 10:09 a.m. UTC | #1
Am 26.11.19 um 01:35 schrieb Jules Irenge:
> Replace 0 with NULL to fix sparse tool  warning
>   warning: Using plain integer as NULL pointer
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/radeon/radeon_audio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_audio.c b/drivers/gpu/drm/radeon/radeon_audio.c
> index b9aea5776d3d..2269cfced788 100644
> --- a/drivers/gpu/drm/radeon/radeon_audio.c
> +++ b/drivers/gpu/drm/radeon/radeon_audio.c
> @@ -288,7 +288,7 @@ static void radeon_audio_interface_init(struct radeon_device *rdev)
>   	} else {
>   		rdev->audio.funcs = &r600_funcs;
>   		rdev->audio.hdmi_funcs = &r600_hdmi_funcs;
> -		rdev->audio.dp_funcs = 0;
> +		rdev->audio.dp_funcs = NULL;
>   	}
>   }
>
Liu, Zhan Nov. 26, 2019, 2:55 p.m. UTC | #2
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Christian König
> Sent: 2019/November/26, Tuesday 5:10 AM
> To: Jules Irenge <jbi.octave@gmail.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>
> Cc: Zhou, David(ChunMing) <David1.Zhou@amd.com>; airlied@linux.ie;
> linux-kernel@vger.kernel.org; amd-gfx@lists.freedesktop.org; dri-
> devel@lists.freedesktop.org; daniel@ffwll.ch
> Subject: Re: [PATCH] drm: radeon: replace 0 with NULL
> 
> Am 26.11.19 um 01:35 schrieb Jules Irenge:
> > Replace 0 with NULL to fix sparse tool  warning
> >   warning: Using plain integer as NULL pointer
> >
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> 
> Acked-by: Christian König <christian.koenig@amd.com>


Reviewed-by: Zhan Liu <zhan.liu@amd.com>


> 
> > ---
> >   drivers/gpu/drm/radeon/radeon_audio.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_audio.c
> b/drivers/gpu/drm/radeon/radeon_audio.c
> > index b9aea5776d3d..2269cfced788 100644
> > --- a/drivers/gpu/drm/radeon/radeon_audio.c
> > +++ b/drivers/gpu/drm/radeon/radeon_audio.c
> > @@ -288,7 +288,7 @@ static void radeon_audio_interface_init(struct
> radeon_device *rdev)
> >   	} else {
> >   		rdev->audio.funcs = &r600_funcs;
> >   		rdev->audio.hdmi_funcs = &r600_hdmi_funcs;
> > -		rdev->audio.dp_funcs = 0;
> > +		rdev->audio.dp_funcs = NULL;
> >   	}
> >   }
> >
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
Liu, Zhan Nov. 26, 2019, 3:31 p.m. UTC | #3
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Christian König
> Sent: 2019/November/26, Tuesday 5:10 AM
> To: Jules Irenge <jbi.octave@gmail.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>
> Cc: Zhou, David(ChunMing) <David1.Zhou@amd.com>; airlied@linux.ie;
> linux-kernel@vger.kernel.org; amd-gfx@lists.freedesktop.org; dri-
> devel@lists.freedesktop.org; daniel@ffwll.ch
> Subject: Re: [PATCH] drm: radeon: replace 0 with NULL
> 
> Am 26.11.19 um 01:35 schrieb Jules Irenge:
> > Replace 0 with NULL to fix sparse tool  warning
> >   warning: Using plain integer as NULL pointer
> >
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> 
> Acked-by: Christian König <christian.koenig@amd.com>

Reviewed-by: Zhan Liu <zhan.liu@amd.com>

> 
> > ---
> >   drivers/gpu/drm/radeon/radeon_audio.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_audio.c
> b/drivers/gpu/drm/radeon/radeon_audio.c
> > index b9aea5776d3d..2269cfced788 100644
> > --- a/drivers/gpu/drm/radeon/radeon_audio.c
> > +++ b/drivers/gpu/drm/radeon/radeon_audio.c
> > @@ -288,7 +288,7 @@ static void radeon_audio_interface_init(struct
> radeon_device *rdev)
> >   	} else {
> >   		rdev->audio.funcs = &r600_funcs;
> >   		rdev->audio.hdmi_funcs = &r600_hdmi_funcs;
> > -		rdev->audio.dp_funcs = 0;
> > +		rdev->audio.dp_funcs = NULL;
> >   	}
> >   }
> >
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.
> freedesktop.org%2Fmailman%2Flistinfo%2Famd-
> gfx&amp;data=02%7C01%7Czhan.liu%40amd.com%7C35832a2894894c44817d
> 08d77258c9ea%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C1%7C63710
> 3597981850872&amp;sdata=FdouIs7Prawx3UhK4z8AEgV0nYJJcyrGNp56G0w
> hNZU%3D&amp;reserved=0
Alex Deucher Nov. 26, 2019, 4:27 p.m. UTC | #4
Applied.  thanks!

Alex

On Tue, Nov 26, 2019 at 3:15 AM Jules Irenge <jbi.octave@gmail.com> wrote:
>
> Replace 0 with NULL to fix sparse tool  warning
>  warning: Using plain integer as NULL pointer
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/gpu/drm/radeon/radeon_audio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_audio.c b/drivers/gpu/drm/radeon/radeon_audio.c
> index b9aea5776d3d..2269cfced788 100644
> --- a/drivers/gpu/drm/radeon/radeon_audio.c
> +++ b/drivers/gpu/drm/radeon/radeon_audio.c
> @@ -288,7 +288,7 @@ static void radeon_audio_interface_init(struct radeon_device *rdev)
>         } else {
>                 rdev->audio.funcs = &r600_funcs;
>                 rdev->audio.hdmi_funcs = &r600_hdmi_funcs;
> -               rdev->audio.dp_funcs = 0;
> +               rdev->audio.dp_funcs = NULL;
>         }
>  }
>
> --
> 2.23.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/radeon/radeon_audio.c b/drivers/gpu/drm/radeon/radeon_audio.c
index b9aea5776d3d..2269cfced788 100644
--- a/drivers/gpu/drm/radeon/radeon_audio.c
+++ b/drivers/gpu/drm/radeon/radeon_audio.c
@@ -288,7 +288,7 @@  static void radeon_audio_interface_init(struct radeon_device *rdev)
 	} else {
 		rdev->audio.funcs = &r600_funcs;
 		rdev->audio.hdmi_funcs = &r600_hdmi_funcs;
-		rdev->audio.dp_funcs = 0;
+		rdev->audio.dp_funcs = NULL;
 	}
 }