From patchwork Tue Nov 26 09:14:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11261655 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8B7DF913 for ; Tue, 26 Nov 2019 09:14:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7461120678 for ; Tue, 26 Nov 2019 09:14:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7461120678 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BDBC289D64; Tue, 26 Nov 2019 09:14:25 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5AF9C89D64 for ; Tue, 26 Nov 2019 09:14:23 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id f129so2376682wmf.2 for ; Tue, 26 Nov 2019 01:14:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ihuDbTiRhMB9BQRppfpaD8drxLMhNsgPSX/aj6zLSgA=; b=Cnqplp9RugS6/+kFoE5P9pkGx8Z98rYU08k9a+BxfHWROo26x4DENQ3QRfSNokvaMa tc9jRwGDNH62DhdoCyJCcpDTdOL8owP3CXPFmaHRZqMVMRsJmCixUTevxXpi26aJ9auK 4vSsI+yVOKVh93hMGf+Fx3dj31tpqYaAuZaiepazIGft4iFzTTb6gOh4HiQWq+EePnL8 8wDmNW4Opf6y5ZaYlu37Uo/HpT3E3LwrXrcVgiRD5QHT0HusVJqfpx38ZLgz2zCjMo13 zQqjX5czrWb7IOvKoQYrSyiDKLtjPyScJk/4p2e7HYorwhF9qIl5FLluRQzfC/DnwJlb Z4uQ== X-Gm-Message-State: APjAAAXtIe18XuuAyMEfOWywLxqST/02araDaRUG2Hf8dtuYFtDYR+fl OMQrm3sWusNAoKa6VwYNn+mkrfe2x4U= X-Google-Smtp-Source: APXvYqy1MTJRwkyKV5ta+9w5dVc6Tx6thg9nt2NJp4lZSAEvvFJm86S68cvFAELAlq/v71UI69xlYQ== X-Received: by 2002:a7b:c006:: with SMTP id c6mr3302904wmb.52.1574759661689; Tue, 26 Nov 2019 01:14:21 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id j17sm14167450wrr.75.2019.11.26.01.14.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 01:14:20 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 1/2] drm/fourcc: Fill out all block sizes for P10/12/16 Date: Tue, 26 Nov 2019 10:14:13 +0100 Message-Id: <20191126091414.226070-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ihuDbTiRhMB9BQRppfpaD8drxLMhNsgPSX/aj6zLSgA=; b=Fs/YtiVbKpVU0IOAxS43Uc3bYhl8NFbWLO/x1cV7kSUIz+emiVUr13SOB23Fr0bLeA qkqc5KwB1rvHj6fQz+L733zxbUsrgtPkHTUIpVF0ugRtLn+HFk3oQSdV5PeBxGXQDwDs +WqfMkIbf1dwv/coze4CvLZOXTlDxT4TdsHhw= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Daniel Vetter , Randy Li , Daniel Vetter , Ayan Kumar Halder Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" 0 means 1 as the default, but it's mighty confusing if the block size for the first plane is spelled out explicitly, but not for the 2nd plane. No cc: stable because this is just confusion, but 0 functional issue. Fixes: 05f8bc82fc42 ("drm/fourcc: Add new P010, P016 video format") Cc: Daniel Stone Cc: Ville Syrjälä Cc: Randy Li Cc: Clint Taylor Cc: Ayan Kumar Halder Cc: Neil Armstrong Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Signed-off-by: Daniel Vetter Acked-by: Liviu Dudau --- drivers/gpu/drm/drm_fourcc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c index c630064ccf41..fe79ce857c8a 100644 --- a/drivers/gpu/drm/drm_fourcc.c +++ b/drivers/gpu/drm/drm_fourcc.c @@ -253,13 +253,13 @@ const struct drm_format_info *__drm_format_info(u32 format) .char_per_block = { 8, 0, 0 }, .block_w = { 2, 0, 0 }, .block_h = { 2, 0, 0 }, .hsub = 2, .vsub = 2, .is_yuv = true }, { .format = DRM_FORMAT_P010, .depth = 0, .num_planes = 2, - .char_per_block = { 2, 4, 0 }, .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 }, + .char_per_block = { 2, 4, 0 }, .block_w = { 1, 1, 0 }, .block_h = { 1, 1, 0 }, .hsub = 2, .vsub = 2, .is_yuv = true}, { .format = DRM_FORMAT_P012, .depth = 0, .num_planes = 2, - .char_per_block = { 2, 4, 0 }, .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 }, + .char_per_block = { 2, 4, 0 }, .block_w = { 1, 1, 0 }, .block_h = { 1, 1, 0 }, .hsub = 2, .vsub = 2, .is_yuv = true}, { .format = DRM_FORMAT_P016, .depth = 0, .num_planes = 2, - .char_per_block = { 2, 4, 0 }, .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 }, + .char_per_block = { 2, 4, 0 }, .block_w = { 1, 1, 0 }, .block_h = { 1, 1, 0 }, .hsub = 2, .vsub = 2, .is_yuv = true}, { .format = DRM_FORMAT_P210, .depth = 0, .num_planes = 2, .char_per_block = { 2, 4, 0 },