| Message ID | 20191202133650.11964-1-linux@roeck-us.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n | expand |
On Mon, Dec 02, 2019 at 01:49:47PM -0500, Lyude Paul wrote: > Reviewed-by: Lyude Paul <lyude@redhat.com> > > I'll go ahead and push this to drm-misc-next, thanks! drm-misc-next-fixes since it's in the merge window. drm-misc-next is for 5.6 already. -Daniel > > On Mon, 2019-12-02 at 16:20 +0100, Geert Uytterhoeven wrote: > > On Mon, Dec 2, 2019 at 2:41 PM Guenter Roeck <linux@roeck-us.net> wrote: > > > On systems with STACKTRACE_SUPPORT=n, we get: > > > > > > WARNING: unmet direct dependencies detected for STACKTRACE > > > Depends on [n]: STACKTRACE_SUPPORT > > > Selected by [y]: > > > - STACKDEPOT [=y] > > > > > > and build errors such as: > > > > > > m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save': > > > (.text+0x11c): undefined reference to `save_stack_trace' > > > > > > Add the missing deendency on STACKTRACE_SUPPORT. > > > > > > Fixes: 12a280c72868 ("drm/dp_mst: Add topology ref history tracking for > > > debugging") > > > Cc: Lyude Paul <lyude@redhat.com> > > > Cc: Sean Paul <sean@poorly.run> > > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > > > > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> > > > > Gr{oetje,eeting}s, > > > > Geert > > > -- > Cheers, > Lyude Paul >
On Tue, 2019-12-03 at 10:33 +0100, Daniel Vetter wrote: > On Mon, Dec 02, 2019 at 01:49:47PM -0500, Lyude Paul wrote: > > Reviewed-by: Lyude Paul <lyude@redhat.com> > > > > I'll go ahead and push this to drm-misc-next, thanks! > > drm-misc-next-fixes since it's in the merge window. drm-misc-next is for > 5.6 already. > -Daniel Ahh, that explains things :). Pushed, thanks for the patches! > > > On Mon, 2019-12-02 at 16:20 +0100, Geert Uytterhoeven wrote: > > > On Mon, Dec 2, 2019 at 2:41 PM Guenter Roeck <linux@roeck-us.net> wrote: > > > > On systems with STACKTRACE_SUPPORT=n, we get: > > > > > > > > WARNING: unmet direct dependencies detected for STACKTRACE > > > > Depends on [n]: STACKTRACE_SUPPORT > > > > Selected by [y]: > > > > - STACKDEPOT [=y] > > > > > > > > and build errors such as: > > > > > > > > m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save': > > > > (.text+0x11c): undefined reference to `save_stack_trace' > > > > > > > > Add the missing deendency on STACKTRACE_SUPPORT. > > > > > > > > Fixes: 12a280c72868 ("drm/dp_mst: Add topology ref history tracking > > > > for > > > > debugging") > > > > Cc: Lyude Paul <lyude@redhat.com> > > > > Cc: Sean Paul <sean@poorly.run> > > > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > > > > > > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> > > > > > > Gr{oetje,eeting}s, > > > > > > Geert > > > > > -- > > Cheers, > > Lyude Paul > >
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 1168351267fd..bfdadc3667e0 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -95,6 +95,7 @@ config DRM_KMS_FB_HELPER config DRM_DEBUG_DP_MST_TOPOLOGY_REFS bool "Enable refcount backtrace history in the DP MST helpers" + depends on STACKTRACE_SUPPORT select STACKDEPOT depends on DRM_KMS_HELPER depends on DEBUG_KERNEL
On systems with STACKTRACE_SUPPORT=n, we get: WARNING: unmet direct dependencies detected for STACKTRACE Depends on [n]: STACKTRACE_SUPPORT Selected by [y]: - STACKDEPOT [=y] and build errors such as: m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save': (.text+0x11c): undefined reference to `save_stack_trace' Add the missing deendency on STACKTRACE_SUPPORT. Fixes: 12a280c72868 ("drm/dp_mst: Add topology ref history tracking for debugging") Cc: Lyude Paul <lyude@redhat.com> Cc: Sean Paul <sean@poorly.run> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- drivers/gpu/drm/Kconfig | 1 + 1 file changed, 1 insertion(+)