| Message ID | 20191203100406.9674-4-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/12] drm/pci: Only build drm_pci.c if CONFIG_PCI is set | expand |
Hi Thomas,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.4 v5.4-rc8 v5.4-rc7 next-20191203 v5.4 next-20191203]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/Clean-up-drm_pci-c-h/20191203-181838
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 76bb8b05960c3d1668e6bee7624ed886cbd135ba
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/ast/ast_drv.c: In function 'ast_pci_probe':
>> drivers/gpu/drm/ast/ast_drv.c:90:9: error: implicit declaration of function 'drm_get_pci_dev'; did you mean 'drm_get_edid'? [-Werror=implicit-function-declaration]
return drm_get_pci_dev(pdev, ent, &driver);
^~~~~~~~~~~~~~~
drm_get_edid
cc1: some warnings being treated as errors
vim +90 drivers/gpu/drm/ast/ast_drv.c
5478ad10e7850c Thomas Zimmermann 2018-11-15 85
56550d94cbaeaa Greg Kroah-Hartman 2012-12-21 86 static int ast_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
312fec1405dd54 Dave Airlie 2012-02-29 87 {
5478ad10e7850c Thomas Zimmermann 2018-11-15 88 ast_kick_out_firmware_fb(pdev);
5478ad10e7850c Thomas Zimmermann 2018-11-15 89
312fec1405dd54 Dave Airlie 2012-02-29 @90 return drm_get_pci_dev(pdev, ent, &driver);
312fec1405dd54 Dave Airlie 2012-02-29 91 }
312fec1405dd54 Dave Airlie 2012-02-29 92
:::::: The code at line 90 was first introduced by commit
:::::: 312fec1405dd546ddb3fa6387d54e78f604dd8f8 drm: Initial KMS driver for AST (ASpeed Technologies) 2000 series (v2)
:::::: TO: Dave Airlie <airlied@redhat.com>
:::::: CC: Dave Airlie <airlied@redhat.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c index 9da26750a22d..30aa73a5d9b7 100644 --- a/drivers/gpu/drm/ast/ast_drv.c +++ b/drivers/gpu/drm/ast/ast_drv.c @@ -33,7 +33,6 @@ #include <drm/drm_crtc_helper.h> #include <drm/drm_drv.h> #include <drm/drm_gem_vram_helper.h> -#include <drm/drm_pci.h> #include <drm/drm_probe_helper.h> #include "ast_drv.h"
Including <drm/drm_pci.h> is unnecessary in most cases. Replace these instances. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/ast/ast_drv.c | 1 - 1 file changed, 1 deletion(-)