| Message ID | 20191204114732.28514-13-mihail.atanassov@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: Consolidate initialization | expand |
Hi, On 04/12/2019 12:48, Mihail Atanassov wrote: > No functional change. > Why this particular one has "gpu: drm: bridge" unlike the other patches of the serie ? Neil > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> > --- > drivers/gpu/drm/bridge/sii9234.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c > index f81f81b7051f..bfd3832baa1a 100644 > --- a/drivers/gpu/drm/bridge/sii9234.c > +++ b/drivers/gpu/drm/bridge/sii9234.c > @@ -925,8 +925,7 @@ static int sii9234_probe(struct i2c_client *client, > > i2c_set_clientdata(client, ctx); > > - ctx->bridge.funcs = &sii9234_bridge_funcs; > - ctx->bridge.of_node = dev->of_node; > + drm_bridge_init(&ctx->bridge, dev, &sii9234_bridge_funcs, NULL, NULL); > drm_bridge_add(&ctx->bridge); > > sii9234_cable_in(ctx); >
Hi Neil, On Thursday, 5 December 2019 12:10:37 GMT Neil Armstrong wrote: > Hi, > > On 04/12/2019 12:48, Mihail Atanassov wrote: > > No functional change. > > > > Why this particular one has "gpu: drm: bridge" unlike the other patches of the serie ? > I took the "look at the file's git log" approach to determining the prefix. I can change it if you prefer a "drm/bridge: sii9234" prefix instead. > Neil > > > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> > > --- > > drivers/gpu/drm/bridge/sii9234.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c > > index f81f81b7051f..bfd3832baa1a 100644 > > --- a/drivers/gpu/drm/bridge/sii9234.c > > +++ b/drivers/gpu/drm/bridge/sii9234.c > > @@ -925,8 +925,7 @@ static int sii9234_probe(struct i2c_client *client, > > > > i2c_set_clientdata(client, ctx); > > > > - ctx->bridge.funcs = &sii9234_bridge_funcs; > > - ctx->bridge.of_node = dev->of_node; > > + drm_bridge_init(&ctx->bridge, dev, &sii9234_bridge_funcs, NULL, NULL); > > drm_bridge_add(&ctx->bridge); > > > > sii9234_cable_in(ctx); > > > >
diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c index f81f81b7051f..bfd3832baa1a 100644 --- a/drivers/gpu/drm/bridge/sii9234.c +++ b/drivers/gpu/drm/bridge/sii9234.c @@ -925,8 +925,7 @@ static int sii9234_probe(struct i2c_client *client, i2c_set_clientdata(client, ctx); - ctx->bridge.funcs = &sii9234_bridge_funcs; - ctx->bridge.of_node = dev->of_node; + drm_bridge_init(&ctx->bridge, dev, &sii9234_bridge_funcs, NULL, NULL); drm_bridge_add(&ctx->bridge); sii9234_cable_in(ctx);
No functional change. Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> --- drivers/gpu/drm/bridge/sii9234.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)