diff mbox series

drm/udl: Make udl driver depend on CONFIG_USB

Message ID 20200106141016.9562-1-tzimmermann@suse.de (mailing list archive)
State New, archived
Headers show
Series drm/udl: Make udl driver depend on CONFIG_USB | expand

Commit Message

Thomas Zimmermann Jan. 6, 2020, 2:10 p.m. UTC
The udl driver for DisplayLink devices depends on support for host-side
USB controllers, which is enabled with CONFIG_USB. Plain USB support as
given by CONFIG_USB_SUPPORT not sufficient.

This patch changes dependencies for udl to depend on CONFIG_USB, instead
of CONFIG_USB_SUPPORT. Users will have to enable CONFIG_USB and select a
USB host controller. With this change udl dependencies work the same way
as dependencies for PCI drivers.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/udl/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Alex Deucher Jan. 6, 2020, 3:16 p.m. UTC | #1
On Mon, Jan 6, 2020 at 9:10 AM Thomas Zimmermann <tzimmermann@suse.de> wrote:
>
> The udl driver for DisplayLink devices depends on support for host-side
> USB controllers, which is enabled with CONFIG_USB. Plain USB support as
> given by CONFIG_USB_SUPPORT not sufficient.
>
> This patch changes dependencies for udl to depend on CONFIG_USB, instead
> of CONFIG_USB_SUPPORT. Users will have to enable CONFIG_USB and select a
> USB host controller. With this change udl dependencies work the same way
> as dependencies for PCI drivers.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>

Acked-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/udl/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/udl/Kconfig b/drivers/gpu/drm/udl/Kconfig
> index 065974bf010e..1f497d8f1ae5 100644
> --- a/drivers/gpu/drm/udl/Kconfig
> +++ b/drivers/gpu/drm/udl/Kconfig
> @@ -2,9 +2,8 @@
>  config DRM_UDL
>         tristate "DisplayLink"
>         depends on DRM
> -       depends on USB_SUPPORT
> +       depends on USB
>         depends on USB_ARCH_HAS_HCD
> -       select USB
>         select DRM_GEM_SHMEM_HELPER
>         select DRM_KMS_HELPER
>         help
> --
> 2.24.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/udl/Kconfig b/drivers/gpu/drm/udl/Kconfig
index 065974bf010e..1f497d8f1ae5 100644
--- a/drivers/gpu/drm/udl/Kconfig
+++ b/drivers/gpu/drm/udl/Kconfig
@@ -2,9 +2,8 @@ 
 config DRM_UDL
 	tristate "DisplayLink"
 	depends on DRM
-	depends on USB_SUPPORT
+	depends on USB
 	depends on USB_ARCH_HAS_HCD
-	select USB
 	select DRM_GEM_SHMEM_HELPER
 	select DRM_KMS_HELPER
 	help