| Message ID | 20200123095333.2085810-11-boris.brezillon@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Add support for bus-format negotiation | expand |
On 23/01/2020 10:53, Boris Brezillon wrote: > So that the previous bridge element in the chain knows which input > format the panel bridge expects. > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > Changes in v7: > * Set atomic state hooks explicitly > > Changes in v3: > * Adjust things to match the new bus-format negotiation approach > * Use drm_atomic_helper_bridge_propagate_bus_fmt > * Don't implement ->atomic_check() (the core now takes care of bus > flags propagation) > > Changes in v2: > * Adjust things to match the new bus-format negotiation approach > --- > drivers/gpu/drm/bridge/panel.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > index f66777e24968..dcc72bd7df30 100644 > --- a/drivers/gpu/drm/bridge/panel.c > +++ b/drivers/gpu/drm/bridge/panel.c > @@ -127,6 +127,10 @@ static const struct drm_bridge_funcs panel_bridge_bridge_funcs = { > .enable = panel_bridge_enable, > .disable = panel_bridge_disable, > .post_disable = panel_bridge_post_disable, > + .atomic_reset = drm_atomic_helper_bridge_reset, > + .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, > + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, > + .atomic_get_input_bus_fmts = drm_atomic_helper_bridge_propagate_bus_fmt, > }; > > /** > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
On Thu, Jan 23, 2020 at 10:53:31AM +0100, Boris Brezillon wrote: > So that the previous bridge element in the chain knows which input > format the panel bridge expects. > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> Subject: [PATCH v8 10/12] drm/bridge: panel: Propage bus format/flags s/Propage/Propagate/ ? Sam > --- > Changes in v7: > * Set atomic state hooks explicitly > > Changes in v3: > * Adjust things to match the new bus-format negotiation approach > * Use drm_atomic_helper_bridge_propagate_bus_fmt > * Don't implement ->atomic_check() (the core now takes care of bus > flags propagation) > > Changes in v2: > * Adjust things to match the new bus-format negotiation approach > --- > drivers/gpu/drm/bridge/panel.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > index f66777e24968..dcc72bd7df30 100644 > --- a/drivers/gpu/drm/bridge/panel.c > +++ b/drivers/gpu/drm/bridge/panel.c > @@ -127,6 +127,10 @@ static const struct drm_bridge_funcs panel_bridge_bridge_funcs = { > .enable = panel_bridge_enable, > .disable = panel_bridge_disable, > .post_disable = panel_bridge_post_disable, > + .atomic_reset = drm_atomic_helper_bridge_reset, > + .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, > + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, > + .atomic_get_input_bus_fmts = drm_atomic_helper_bridge_propagate_bus_fmt, > }; > > /** > -- > 2.24.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Fri, 24 Jan 2020 17:25:50 +0100 Sam Ravnborg <sam@ravnborg.org> wrote: > On Thu, Jan 23, 2020 at 10:53:31AM +0100, Boris Brezillon wrote: > > So that the previous bridge element in the chain knows which input > > format the panel bridge expects. > > > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > > Subject: [PATCH v8 10/12] drm/bridge: panel: Propage bus format/flags > s/Propage/Propagate/ > ? > Oops. I'll fix it when applying, unless there are other things to fix in the v8.
diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c index f66777e24968..dcc72bd7df30 100644 --- a/drivers/gpu/drm/bridge/panel.c +++ b/drivers/gpu/drm/bridge/panel.c @@ -127,6 +127,10 @@ static const struct drm_bridge_funcs panel_bridge_bridge_funcs = { .enable = panel_bridge_enable, .disable = panel_bridge_disable, .post_disable = panel_bridge_post_disable, + .atomic_reset = drm_atomic_helper_bridge_reset, + .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, + .atomic_get_input_bus_fmts = drm_atomic_helper_bridge_propagate_bus_fmt, }; /**
So that the previous bridge element in the chain knows which input format the panel bridge expects. Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> --- Changes in v7: * Set atomic state hooks explicitly Changes in v3: * Adjust things to match the new bus-format negotiation approach * Use drm_atomic_helper_bridge_propagate_bus_fmt * Don't implement ->atomic_check() (the core now takes care of bus flags propagation) Changes in v2: * Adjust things to match the new bus-format negotiation approach --- drivers/gpu/drm/bridge/panel.c | 4 ++++ 1 file changed, 4 insertions(+)