From patchwork Fri Feb 21 21:03:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11397537 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 307551580 for ; Fri, 21 Feb 2020 21:05:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F2422073A for ; Fri, 21 Feb 2020 21:05:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="YziQNNSE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F2422073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F6116F579; Fri, 21 Feb 2020 21:05:10 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8347B6F553 for ; Fri, 21 Feb 2020 21:04:29 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id s144so6021449wme.1 for ; Fri, 21 Feb 2020 13:04:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q7TJHDqj8/6sjzRbpshntBJrPdaYH+7eV+1SBaB2f20=; b=YziQNNSE/lfKhLi6ZWejNGDW4jUch+lLVmNecFQ5UPrC0q5bpzQLMZvhtZuH/8aer9 WtHDrFOUh+l3xOtAwtc8iuqchUni8/1fnhw5eSWW/pmDchAjvsAJYVMV6GNA2iIdND9B safaK5KORAPzeCyeePLoSwTl39AFyAFxDtcZo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q7TJHDqj8/6sjzRbpshntBJrPdaYH+7eV+1SBaB2f20=; b=ZsvUDpi5s0/eP+2RorQvMEKrEdhthMGyTUHyTle1kp8HL36gvGvY362u30oL8aLeVe sbcRAYsHVADAAzZtiEwAHJ0HUN3/NYMgR2b4KwEdCziQkF0zsF2gIxzxyY5sDKh4HZWr cNJgXPYJpOAoyETNSLyZSPXgHfqbC4nV1VVjgC4NQKi/5PX+SVMdZ1HGJ/zDc0t826H5 yviQ7mLwoAlgQOxGrK+SWNhsfyFBt4wRj+lqXV678o9YW02KTFk1bGzFD6rH/ZfjO6mX THlzQhCU+15pjLAEHBuhodVce2BzitqQ2b+Iew34NrooXQKwjxBgxeAnlHkwNv1xGxYU XGBw== X-Gm-Message-State: APjAAAXFaLsMA2tn2hiGhqoXb1UyS4/7kxOSxjbTjM3G+daPL+Sdg6vt KtLNnTeLGt2MkU8jVu+eDJbDdTs445c= X-Google-Smtp-Source: APXvYqwb3u7l1V9rPgXQIvLanfU/oDqtBDxrk81XG7Uim5jvXkUfQy8NhMJYQ3jl2jSIJpHFfs4g4A== X-Received: by 2002:a7b:c416:: with SMTP id k22mr5937348wmi.25.1582319068082; Fri, 21 Feb 2020 13:04:28 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id z6sm5483930wrw.36.2020.02.21.13.04.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2020 13:04:27 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 46/51] drm/repaper: Drop explicit drm_mode_config_cleanup call Date: Fri, 21 Feb 2020 22:03:14 +0100 Message-Id: <20200221210319.2245170-47-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200221210319.2245170-1-daniel.vetter@ffwll.ch> References: <20200221210319.2245170-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Laurent Pinchart , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Allows us to drop the drm_driver.release callback. This is made possible by a preceeding patch which added a drmm_ cleanup action to drm_mode_config_init(), hence all we need to do to ensure that drm_mode_config_cleanup() is run on final drm_device cleanup is check the new error code for _init(). v2: Explain why this cleanup is possible (Laurent). Cc: Laurent Pinchart Reviewed-by: Noralf Trønnes Signed-off-by: Daniel Vetter Cc: "Noralf Trønnes" --- drivers/gpu/drm/tiny/repaper.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/tiny/repaper.c b/drivers/gpu/drm/tiny/repaper.c index 4741ff670ec9..2f70fb1be200 100644 --- a/drivers/gpu/drm/tiny/repaper.c +++ b/drivers/gpu/drm/tiny/repaper.c @@ -909,13 +909,6 @@ static const struct drm_mode_config_funcs repaper_mode_config_funcs = { .atomic_commit = drm_atomic_helper_commit, }; -static void repaper_release(struct drm_device *drm) -{ - DRM_DEBUG_DRIVER("\n"); - - drm_mode_config_cleanup(drm); -} - static const uint32_t repaper_formats[] = { DRM_FORMAT_XRGB8888, }; @@ -953,7 +946,6 @@ DEFINE_DRM_GEM_CMA_FOPS(repaper_fops); static struct drm_driver repaper_driver = { .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, .fops = &repaper_fops, - .release = repaper_release, DRM_GEM_CMA_VMAP_DRIVER_OPS, .name = "repaper", .desc = "Pervasive Displays RePaper e-ink panels",