| Message ID | 20200227120232.19413-7-wambui.karugax@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: subsytem-wide debugfs functions refactor | expand |
Hi Wambui, > -----Original Message----- > From: Wambui Karuga <wambui.karugax@gmail.com> > Sent: Thursday, February 27, 2020 7:02 PM > To: daniel@ffwll.ch; airlied@linux.ie; Alexey Brodkin <abrodkin@synopsys.com> > Cc: linux-kernel@vger.kernel.org; gregkh@linuxfoundation.org; dri-devel@lists.freedesktop.org > Subject: [PATCH 06/21] drm/arc: make arcpgu_debugfs_init return void > > Since commit 987d65d01356 (drm: debugfs: make > drm_debugfs_create_files() never fail), drm_debugfs_create_files never > fails and should return void. Therefore, remove its use as the > return value of arcpgu_debugfs_init and have the latter function also > return void. > > Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com> Thanks for this clean-up and Acked-by: Alexey Brodkin <abrodkin@synopsys.com>
diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c index d6a6692db0ac..c05d001163e0 100644 --- a/drivers/gpu/drm/arc/arcpgu_drv.c +++ b/drivers/gpu/drm/arc/arcpgu_drv.c @@ -137,10 +137,11 @@ static struct drm_info_list arcpgu_debugfs_list[] = { { "clocks", arcpgu_show_pxlclock, 0 }, }; -static int arcpgu_debugfs_init(struct drm_minor *minor) +static void arcpgu_debugfs_init(struct drm_minor *minor) { - return drm_debugfs_create_files(arcpgu_debugfs_list, - ARRAY_SIZE(arcpgu_debugfs_list), minor->debugfs_root, minor); + drm_debugfs_create_files(arcpgu_debugfs_list, + ARRAY_SIZE(arcpgu_debugfs_list), + minor->debugfs_root, minor); } #endif
Since commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files never fails and should return void. Therefore, remove its use as the return value of arcpgu_debugfs_init and have the latter function also return void. Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com> --- drivers/gpu/drm/arc/arcpgu_drv.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)