From patchwork Mon Mar 2 22:25:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11416525 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E260117E0 for ; Mon, 2 Mar 2020 22:27:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0CEE20866 for ; Mon, 2 Mar 2020 22:27:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="H9TqljHA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0CEE20866 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5CD556E871; Mon, 2 Mar 2020 22:26:57 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6776E6E87A for ; Mon, 2 Mar 2020 22:26:54 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id 6so825595wmi.5 for ; Mon, 02 Mar 2020 14:26:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ajU8ZGbEcqkBckAYEDiRNz0MsdPI1TPZqA43HvlugAA=; b=H9TqljHATSEOas5/z3pB0sLxFqmY4QJ1lKcrkrm/K+nQXUIjJvkTeSloG/d4HjKzZP oB4t5WOyrQ9RvNccEU96AvdGiLx/bUOJoMMySLC1Rsux3YU5u8g6YSbW3taUbod67G/k SMDhFsGrurpKzvz7LNsG9Uxn6sc016suc/yGg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ajU8ZGbEcqkBckAYEDiRNz0MsdPI1TPZqA43HvlugAA=; b=nxaJ28kzPcdwKvd1eVgMtF53FUiNv7uVBjnYSYLHXjGVQ/klsQiGCZZj4MoFLHf4V2 COH5e2i5RX98dChEtDJ5u3YA6/tUiwWnklAIirdluWPd/Ek/psj2/vCfNbSgxbDemQ9e 4/Z0KeKssTYGRtpOQm7E9Uy2T709q7Hk74ZKlOeIMZSvxjWD2CJBF8dUczILpLjp0Llq 8kU84hHM7Lspm1tzIHnptb36IY4KiHIUWggaFBT/5ubRjLSW68TxUfCN8vTlE6cZNmqB JuHG+unsopB6LR3T72utP9Ps3kiTIW9/G5rZNvK45KUW6kudIpkEE/tlpX037RgCGAY5 uypg== X-Gm-Message-State: ANhLgQ2Fhwz1+eFbteLONp7W6wc5v89jysoLUh4gSFXJ7J5lN8eBZT4X zVGqNYK+bRuOTfIAwBcedcMg063vjio= X-Google-Smtp-Source: ADFU+vt515+IoI2nlY/7PIrHtdASFHlJ4ud3mOV0GBnjzkTNUI8qKr7w0BKWovMbdZLvqVx2n7HrHg== X-Received: by 2002:a1c:155:: with SMTP id 82mr466434wmb.99.1583188012778; Mon, 02 Mar 2020 14:26:52 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id o18sm26114589wrv.60.2020.03.02.14.26.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2020 14:26:52 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 09/51] drm/cirrus: Use drmm_add_final_kfree Date: Mon, 2 Mar 2020 23:25:49 +0100 Message-Id: <20200302222631.3861340-10-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200302222631.3861340-1-daniel.vetter@ffwll.ch> References: <20200302222631.3861340-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , virtualization@lists.linux-foundation.org, Gerd Hoffmann , Thomas Zimmermann , Daniel Vetter , Dave Airlie , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" With this we can drop the final kfree from the release function. I also noticed that cirrus forgot to call drm_dev_fini(). v2: Don't call kfree(cirrus) after we've handed overship of that to drm_device and the drmm_ stuff. Acked-by: Sam Ravnborg Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Gerd Hoffmann Cc: Daniel Vetter Cc: "Noralf Trønnes" Cc: Linus Walleij Cc: Sam Ravnborg Cc: Thomas Zimmermann Cc: virtualization@lists.linux-foundation.org Acked-by: Gerd Hoffmann --- drivers/gpu/drm/cirrus/cirrus.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/cirrus/cirrus.c b/drivers/gpu/drm/cirrus/cirrus.c index d2ff63ce8eaf..2232556ce34c 100644 --- a/drivers/gpu/drm/cirrus/cirrus.c +++ b/drivers/gpu/drm/cirrus/cirrus.c @@ -35,6 +35,7 @@ #include #include #include +#include #include #include #include @@ -527,10 +528,8 @@ static void cirrus_mode_config_init(struct cirrus_device *cirrus) static void cirrus_release(struct drm_device *dev) { - struct cirrus_device *cirrus = dev->dev_private; - drm_mode_config_cleanup(dev); - kfree(cirrus); + drm_dev_fini(dev); } DEFINE_DRM_GEM_FOPS(cirrus_fops); @@ -575,9 +574,12 @@ static int cirrus_pci_probe(struct pci_dev *pdev, dev = &cirrus->dev; ret = drm_dev_init(dev, &cirrus_driver, &pdev->dev); - if (ret) - goto err_free_cirrus; + if (ret) { + kfree(cirrus); + goto err_pci_release; + } dev->dev_private = cirrus; + drmm_add_final_kfree(dev, cirrus); ret = -ENOMEM; cirrus->vram = ioremap(pci_resource_start(pdev, 0), @@ -618,8 +620,6 @@ static int cirrus_pci_probe(struct pci_dev *pdev, iounmap(cirrus->vram); err_dev_put: drm_dev_put(dev); -err_free_cirrus: - kfree(cirrus); err_pci_release: pci_release_regions(pdev); return ret;