diff mbox series

[5/5] drm/virtio: only call virtio_gpu_cmd_create_resource for dumb resources

Message ID 20200401223039.2860-5-gurchetansingh@chromium.org (mailing list archive)
State New, archived
Headers show
Series [1/5] drm/virtio: random virtgpu_drv.h cleanups | expand

Commit Message

Gurchetan Singh April 1, 2020, 10:30 p.m. UTC
We want to avoid this path for upcoming blob resources.

Signed-off-by: Gurchetan Singh <gurchetansingh@chromium.org>
---
 drivers/gpu/drm/virtio/virtgpu_object.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gerd Hoffmann April 3, 2020, 10:04 a.m. UTC | #1
On Wed, Apr 01, 2020 at 03:30:39PM -0700, Gurchetan Singh wrote:
> We want to avoid this path for upcoming blob resources.

> -	} else {
> +	} else if (params->dumb) {

That should be posted as part of the actual blob resource patch series,
it doesn't make sense at all standalone.

The other patches 1-4 are fine, I'll go push them in a moment.

take care,
  Gerd
diff mbox series

Patch

diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virtio/virtgpu_object.c
index 6ccbd01cd888c..82df066ac0552 100644
--- a/drivers/gpu/drm/virtio/virtgpu_object.c
+++ b/drivers/gpu/drm/virtio/virtgpu_object.c
@@ -224,7 +224,7 @@  int virtio_gpu_object_create(struct virtio_gpu_device *vgdev,
 	if (params->virgl) {
 		virtio_gpu_cmd_resource_create_3d(vgdev, bo, params,
 						  objs, fence);
-	} else {
+	} else if (params->dumb) {
 		virtio_gpu_cmd_create_resource(vgdev, bo, params,
 					       objs, fence);
 	}