diff mbox series

[v2,1/2] dt-bindings: display: simple: Add IVO M133NWF4 R0

Message ID 20200420215728.1927434-1-bjorn.andersson@linaro.org (mailing list archive)
State New, archived
Headers show
Series [v2,1/2] dt-bindings: display: simple: Add IVO M133NWF4 R0 | expand

Commit Message

Bjorn Andersson April 20, 2020, 9:57 p.m. UTC
Define the vendor prefix for InfoVision Optoelectronics and add their
M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel to the compatible list
of panel-simple.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---

Changes since v1:
- Added this patch

 .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
 Documentation/devicetree/bindings/vendor-prefixes.yaml          | 2 ++
 2 files changed, 4 insertions(+)

Comments

Sam Ravnborg April 25, 2020, 5:58 p.m. UTC | #1
Hi Björn.

On Mon, Apr 20, 2020 at 02:57:27PM -0700, Bjorn Andersson wrote:
> Define the vendor prefix for InfoVision Optoelectronics and add their
> M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel to the compatible list
> of panel-simple.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

I got OK for the vendor prefix on irc so patch is now added to
drm-misc-next.
Another time please use a dedicated patch for vendor-prefix
so it is not hidden with other stuff. This way the chance
to get the attention of the right people is better.

Also added the panel-simple patch.
Both pushed out now.

	Sam

> ---
> 
> Changes since v1:
> - Added this patch
> 
>  .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
>  Documentation/devicetree/bindings/vendor-prefixes.yaml          | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index daf86ba18f47..31dc88f5b2a9 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -129,6 +129,8 @@ properties:
>        - hannstar,hsd100pxn1
>          # Hitachi Ltd. Corporation 9" WVGA (800x480) TFT LCD panel
>        - hit,tx23d38vm0caa
> +        # InfoVision Optoelectronics M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel
> +      - ivo,m133nwf4-r0
>          # Innolux AT043TN24 4.3" WQVGA TFT LCD panel
>        - innolux,at043tn24
>          # Innolux AT070TN92 7.0" WQVGA TFT LCD panel
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index d3891386d671..31012f91fb9a 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -463,6 +463,8 @@ patternProperties:
>      description: Infineon Technologies
>    "^inforce,.*":
>      description: Inforce Computing
> +  "^ivo,.*":
> +    description: InfoVision Optoelectronics Kunshan Co. Ltd.
>    "^ingenic,.*":
>      description: Ingenic Semiconductor
>    "^innolux,.*":
> -- 
> 2.26.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Rob Herring April 28, 2020, 2:27 p.m. UTC | #2
On Sat, Apr 25, 2020 at 12:58 PM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Björn.
>
> On Mon, Apr 20, 2020 at 02:57:27PM -0700, Bjorn Andersson wrote:
> > Define the vendor prefix for InfoVision Optoelectronics and add their
> > M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel to the compatible list
> > of panel-simple.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> I got OK for the vendor prefix on irc so patch is now added to
> drm-misc-next.
> Another time please use a dedicated patch for vendor-prefix
> so it is not hidden with other stuff. This way the chance
> to get the attention of the right people is better.

I should have mentioned there's basically one thing to check:
alphabetical order.

The good news is both files got it wrong, so at least we're consistent. :)

Rob
Sam Ravnborg April 28, 2020, 5:05 p.m. UTC | #3
Hi Rob.

On Tue, Apr 28, 2020 at 09:27:51AM -0500, Rob Herring wrote:
> On Sat, Apr 25, 2020 at 12:58 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> >
> > Hi Björn.
> >
> > On Mon, Apr 20, 2020 at 02:57:27PM -0700, Bjorn Andersson wrote:
> > > Define the vendor prefix for InfoVision Optoelectronics and add their
> > > M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel to the compatible list
> > > of panel-simple.
> > >
> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> >
> > I got OK for the vendor prefix on irc so patch is now added to
> > drm-misc-next.
> > Another time please use a dedicated patch for vendor-prefix
> > so it is not hidden with other stuff. This way the chance
> > to get the attention of the right people is better.
> 
> I should have mentioned there's basically one thing to check:
> alphabetical order.
I thought I checked that, but obviously not - hrmpf..
I will post a follow-up patch for drm-misc-next to fix it.

	Sam
Bjorn Andersson April 28, 2020, 6:02 p.m. UTC | #4
On Tue 28 Apr 10:05 PDT 2020, Sam Ravnborg wrote:

> Hi Rob.
> 
> On Tue, Apr 28, 2020 at 09:27:51AM -0500, Rob Herring wrote:
> > On Sat, Apr 25, 2020 at 12:58 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> > >
> > > Hi Björn.
> > >
> > > On Mon, Apr 20, 2020 at 02:57:27PM -0700, Bjorn Andersson wrote:
> > > > Define the vendor prefix for InfoVision Optoelectronics and add their
> > > > M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel to the compatible list
> > > > of panel-simple.
> > > >
> > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > >
> > > I got OK for the vendor prefix on irc so patch is now added to
> > > drm-misc-next.
> > > Another time please use a dedicated patch for vendor-prefix
> > > so it is not hidden with other stuff. This way the chance
> > > to get the attention of the right people is better.
> > 
> > I should have mentioned there's basically one thing to check:
> > alphabetical order.
> I thought I checked that, but obviously not - hrmpf..

Sorry about that, I thought I did double check that before posting it...

> I will post a follow-up patch for drm-misc-next to fix it.
> 

Thank you,
Bjorn
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index daf86ba18f47..31dc88f5b2a9 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -129,6 +129,8 @@  properties:
       - hannstar,hsd100pxn1
         # Hitachi Ltd. Corporation 9" WVGA (800x480) TFT LCD panel
       - hit,tx23d38vm0caa
+        # InfoVision Optoelectronics M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel
+      - ivo,m133nwf4-r0
         # Innolux AT043TN24 4.3" WQVGA TFT LCD panel
       - innolux,at043tn24
         # Innolux AT070TN92 7.0" WQVGA TFT LCD panel
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index d3891386d671..31012f91fb9a 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -463,6 +463,8 @@  patternProperties:
     description: Infineon Technologies
   "^inforce,.*":
     description: Inforce Computing
+  "^ivo,.*":
+    description: InfoVision Optoelectronics Kunshan Co. Ltd.
   "^ingenic,.*":
     description: Ingenic Semiconductor
   "^innolux,.*":