| Message ID | 20200426131244.22293-1-bernard@vivo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/radeon: cleanup coding style a bit | expand |
Applied. Thanks! Alex On Sun, Apr 26, 2020 at 9:18 AM Christian König <christian.koenig@amd.com> wrote: > > Am 26.04.20 um 15:12 schrieb Bernard Zhao: > > Maybe no need to check ws before kmalloc, kmalloc will check > > itself, kmalloc`s logic is if ptr is NULL, kmalloc will just > > return > > > > Signed-off-by: Bernard Zhao <bernard@vivo.com> > > Reviewed-by: Christian König <christian.koenig@amd.com> > > I'm wondering why the automated scripts haven't found that one before. > > > --- > > drivers/gpu/drm/radeon/atom.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c > > index 2c27627b6659..f15b20da5315 100644 > > --- a/drivers/gpu/drm/radeon/atom.c > > +++ b/drivers/gpu/drm/radeon/atom.c > > @@ -1211,8 +1211,7 @@ static int atom_execute_table_locked(struct atom_context *ctx, int index, uint32 > > SDEBUG("<<\n"); > > > > free: > > - if (ws) > > - kfree(ectx.ws); > > + kfree(ectx.ws); > > return ret; > > } > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c index 2c27627b6659..f15b20da5315 100644 --- a/drivers/gpu/drm/radeon/atom.c +++ b/drivers/gpu/drm/radeon/atom.c @@ -1211,8 +1211,7 @@ static int atom_execute_table_locked(struct atom_context *ctx, int index, uint32 SDEBUG("<<\n"); free: - if (ws) - kfree(ectx.ws); + kfree(ectx.ws); return ret; }
Maybe no need to check ws before kmalloc, kmalloc will check itself, kmalloc`s logic is if ptr is NULL, kmalloc will just return Signed-off-by: Bernard Zhao <bernard@vivo.com> --- drivers/gpu/drm/radeon/atom.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)