From patchwork Mon Apr 27 08:18:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11511471 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BDC28912 for ; Mon, 27 Apr 2020 08:19:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C2412087E for ; Mon, 27 Apr 2020 08:19:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uQYGN/yZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C2412087E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E420B6E0E4; Mon, 27 Apr 2020 08:19:35 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by gabe.freedesktop.org (Postfix) with ESMTPS id 51B1B89FA9 for ; Mon, 27 Apr 2020 08:19:09 +0000 (UTC) Received: by mail-lf1-x142.google.com with SMTP id 198so13088433lfo.7 for ; Mon, 27 Apr 2020 01:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j1wBVGWZBLJGGWmZJQCkiiFA5pJ4Zh7uYCZioqKNsMQ=; b=uQYGN/yZ+slEiAp8AXhG6nk6Wy37f6UQ3NfK3AFXAS3QBAL1ZoIlBjS8qybs75MmS4 2csxIuzMp97bwTFQqyBovljNX2Ii8IwCwtMKFoXhcDwqUrAPwic7w8e72nUtnGiyIi0e vi3v1zjVB6FFhNM1CUrfuXd3Bvl8CKd9j6PsDiK9xCneKhbgaj8R/eCVFg9DQR2yB6l8 XKIHyIc5O4N6ptjj8wPQEm5zBrCJYx1Xz8zXez3TIqRs7JQgmCt6bc92acg7hYS6OG65 57zTd1XaAbcjJXV1kGyt3FAXsyBMR6a8s6e3UlXf+WnGIYhHHj/nXB0d9nCOUDmooW49 YBrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=j1wBVGWZBLJGGWmZJQCkiiFA5pJ4Zh7uYCZioqKNsMQ=; b=NkiNqkw6dQ0xSlVlxrYt7i0wdzpfrXT6mCuNMVPzSQ70dCdBPEzXnADHQq1gmAYEt9 SEB0IIQdwAVgLEfWGjeTOCU32aR7/hJZXwkqbxFWiPmswELIXRJB187fb4W2BNDxh/TR mv+08IZlrBxDq4SVXdfTlTTXMjE5OZXpI9j6f6d9LrLI0no8GTRnP3j0n7EF2NmI2+AL +0xA1pJH6uo63ygbNpolDCTZzqWcu0022xxy62AeZVqi1GDglUXGYt/Xp2D2NkpNdO34 LyvFh+n3FneFcGbOC/Y5OAQ0AioV2nhRc/qiI2oysWRXfNhwmU+bSeT56ZO+46mhbqm3 WySQ== X-Gm-Message-State: AGi0PubiiF+ihBQtQ/RRdzb4yYTYhFOe3ZwjM4Mot/gmG5IuJ4ZY5Uv+ 2TU+i0N/9g2wqJiBsCEGVUdTzldS X-Google-Smtp-Source: APiQypJFSsoeMZ4dE5xMtoyir41iPjdtqvWNur4Tex5WqQ1ys1T3i5JdBanYln1R0vA7JYn6D4rNGQ== X-Received: by 2002:a05:6512:31c1:: with SMTP id j1mr14994254lfe.14.1587975547448; Mon, 27 Apr 2020 01:19:07 -0700 (PDT) Received: from saturn.lan (18.158-248-194.customer.lyse.net. [158.248.194.18]) by smtp.gmail.com with ESMTPSA id c20sm9846301ljk.59.2020.04.27.01.19.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2020 01:19:06 -0700 (PDT) From: Sam Ravnborg To: dri-devel@lists.freedesktop.org, Laurent Pinchart , Neil Armstrong Subject: [PATCH v2 05/21] drm/bridge: tc358764: make connector creation optional Date: Mon, 27 Apr 2020 10:18:34 +0200 Message-Id: <20200427081850.17512-6-sam@ravnborg.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200427081850.17512-1-sam@ravnborg.org> References: <20200427081850.17512-1-sam@ravnborg.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Martyn Welch , Jonas Karlman , Peter Senna Tschudin , Andrzej Hajda , Thierry Reding , Laurent Pinchart , Sam Ravnborg , Martin Donnelly Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Make the connector creation optional to enable usage of the tc358764 bridge with the DRM bridge connector helper. Signed-off-by: Sam Ravnborg Reviewed-by: Laurent Pinchart Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec --- drivers/gpu/drm/bridge/tc358764.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358764.c b/drivers/gpu/drm/bridge/tc358764.c index 3adb2c191499..4013add64119 100644 --- a/drivers/gpu/drm/bridge/tc358764.c +++ b/drivers/gpu/drm/bridge/tc358764.c @@ -337,10 +337,8 @@ static int tc358764_attach(struct drm_bridge *bridge, if (ret < 0) return ret; - if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) { - DRM_ERROR("Fix bridge driver to make connector optional!"); - return -EINVAL; - } + if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) + return 0; ctx->connector.polled = DRM_CONNECTOR_POLL_HPD; ret = drm_connector_init(drm, &ctx->connector,