| Message ID | 20200429143238.10115-10-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/mgag200: Convert to atomic modesetting | expand |
On Wed, Apr 29, 2020 at 04:32:30PM +0200, Thomas Zimmermann wrote: > Setting the plane registers first and the mode registers afterwards > reproduces the sequence used by atomic helpers. Done in preparation > of switching to simple KMS helpers. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Sam Ravnborg <sam@ravnborg.org> > --- > drivers/gpu/drm/mgag200/mgag200_mode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c > index b5bb02e9f05d6..92dee31f16c42 100644 > --- a/drivers/gpu/drm/mgag200/mgag200_mode.c > +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c > @@ -1146,8 +1146,6 @@ static int mga_crtc_mode_set(struct drm_crtc *crtc, > WREG_CRT(15, 0); > WREG_CRT(19, pitch & 0xFF); > > - mgag200_set_mode_regs(mdev, mode); > - > ext_vga[0] = 0; > > /* TODO interlace */ > @@ -1183,6 +1181,8 @@ static int mga_crtc_mode_set(struct drm_crtc *crtc, > > mga_crtc_do_set_base(mdev, fb, old_fb); > > + mgag200_set_mode_regs(mdev, mode); > + > /* reset tagfifo */ > if (mdev->type == G200_ER) { > u32 mem_ctl = RREG32(MGAREG_MEMCTL); > -- > 2.26.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index b5bb02e9f05d6..92dee31f16c42 100644 --- a/drivers/gpu/drm/mgag200/mgag200_mode.c +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c @@ -1146,8 +1146,6 @@ static int mga_crtc_mode_set(struct drm_crtc *crtc, WREG_CRT(15, 0); WREG_CRT(19, pitch & 0xFF); - mgag200_set_mode_regs(mdev, mode); - ext_vga[0] = 0; /* TODO interlace */ @@ -1183,6 +1181,8 @@ static int mga_crtc_mode_set(struct drm_crtc *crtc, mga_crtc_do_set_base(mdev, fb, old_fb); + mgag200_set_mode_regs(mdev, mode); + /* reset tagfifo */ if (mdev->type == G200_ER) { u32 mem_ctl = RREG32(MGAREG_MEMCTL);
Setting the plane registers first and the mode registers afterwards reproduces the sequence used by atomic helpers. Done in preparation of switching to simple KMS helpers. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/mgag200/mgag200_mode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)