| Message ID | 20200505045737.185143-1-chentao107@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] drm/radeon: fix unsigned comparison with 0 | expand |
On Tue, May 5, 2020 at 2:59 AM ChenTao <chentao107@huawei.com> wrote: > > Fixes warning because pipe is unsigned long and can never be negtative > > vers/gpu/drm/radeon/radeon_kms.c:831:11: warning: > comparison of unsigned expression < 0 is always false [-Wtype-limits] > if (pipe < 0 || pipe >= rdev->num_crtc) { > drivers/gpu/drm/radeon/radeon_kms.c:857:11: warning: > comparison of unsigned expression < 0 is always false [-Wtype-limits] > if (pipe < 0 || pipe >= rdev->num_crtc) { > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: ChenTao <chentao107@huawei.com> Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/radeon_kms.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/radeon_kms.c > index 372962358a18..c5d1dc9618a4 100644 > --- a/drivers/gpu/drm/radeon/radeon_kms.c > +++ b/drivers/gpu/drm/radeon/radeon_kms.c > @@ -828,7 +828,7 @@ int radeon_enable_vblank_kms(struct drm_crtc *crtc) > unsigned long irqflags; > int r; > > - if (pipe < 0 || pipe >= rdev->num_crtc) { > + if (pipe >= rdev->num_crtc) { > DRM_ERROR("Invalid crtc %d\n", pipe); > return -EINVAL; > } > @@ -854,7 +854,7 @@ void radeon_disable_vblank_kms(struct drm_crtc *crtc) > struct radeon_device *rdev = dev->dev_private; > unsigned long irqflags; > > - if (pipe < 0 || pipe >= rdev->num_crtc) { > + if (pipe >= rdev->num_crtc) { > DRM_ERROR("Invalid crtc %d\n", pipe); > return; > } > -- > 2.22.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/radeon_kms.c index 372962358a18..c5d1dc9618a4 100644 --- a/drivers/gpu/drm/radeon/radeon_kms.c +++ b/drivers/gpu/drm/radeon/radeon_kms.c @@ -828,7 +828,7 @@ int radeon_enable_vblank_kms(struct drm_crtc *crtc) unsigned long irqflags; int r; - if (pipe < 0 || pipe >= rdev->num_crtc) { + if (pipe >= rdev->num_crtc) { DRM_ERROR("Invalid crtc %d\n", pipe); return -EINVAL; } @@ -854,7 +854,7 @@ void radeon_disable_vblank_kms(struct drm_crtc *crtc) struct radeon_device *rdev = dev->dev_private; unsigned long irqflags; - if (pipe < 0 || pipe >= rdev->num_crtc) { + if (pipe >= rdev->num_crtc) { DRM_ERROR("Invalid crtc %d\n", pipe); return; }
Fixes warning because pipe is unsigned long and can never be negtative vers/gpu/drm/radeon/radeon_kms.c:831:11: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] if (pipe < 0 || pipe >= rdev->num_crtc) { drivers/gpu/drm/radeon/radeon_kms.c:857:11: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] if (pipe < 0 || pipe >= rdev->num_crtc) { Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: ChenTao <chentao107@huawei.com> --- drivers/gpu/drm/radeon/radeon_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)