From patchwork Fri May 15 09:50:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 11550891 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B70F890 for ; Fri, 15 May 2020 09:54:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9632E2074D for ; Fri, 15 May 2020 09:54:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X0h5Z+wn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9632E2074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D2CAD6EC39; Fri, 15 May 2020 09:54:13 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 259046EC35; Fri, 15 May 2020 09:54:11 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id z72so1960682wmc.2; Fri, 15 May 2020 02:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LUExjU2XTxgqMjmujYynjDialW7+jMU42M0B+uiUV/Y=; b=X0h5Z+wnnFQqU6TpwFt8Qf61V+AHZDickaWHmnAHSyFr6KI8IhuKs62GnZReh6xCV8 ssPiGBYonSSQhW9Yf314A6TlNm3al4GgLEoj2FOeRTYH2R71X8O/TxJG8rXALCBnRB3Q WH17mTvM/JpboS8M0vRzAfh8RVTJSoB6SMabBqdKwdCXB+TJQvh3XqDqxLcfUT0xUM1r RvcfI3NDRUW03mdCec7PK7rkZlPU8lNVeZ6SI7pZVkw+186zmPn3UFni5VmZUiXZDU2U Yllv1Nsgk17LvhbzjZDrRkfkGN/KY1LbHLIBxcrJjQbWNTqioMVLSbZNhJxogOVmZ47C zBYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LUExjU2XTxgqMjmujYynjDialW7+jMU42M0B+uiUV/Y=; b=cq2az1PvTEc+t7IUPYQz+HsobA8Nq8xYIzA0PFAqbEgjIRERpO1vmtk22I2kVT4zcZ yE8K1UDymn//kjiuOxRK60WJarfnQU0/07CmEJZHp8L/7xrMuE8jTERivM7VZxPjUNds E3fgcfONxU3bXnisWy0xP7x4WDpqkhdHTsK4nqjlr7oouXsoTf8YPDmfYidr0iM28RYA UgcS4qvAzazOcosI5a/ALn24wAk7zhf4JvwAfJfCKnkVT0nY5xvbZ5/FAePhIQbTSD94 tLkfdwW+nonMavte4cT75CKumYi/pr0o5R9nZo5zYBIcugicpKiBd6Dlbqsp9Ovv3SFu 8rMA== X-Gm-Message-State: AOAM530o4YutJTb2ZWy7809l/ReE5RbAxkTHvRW41AW70rMsIlbqWae8 zRVoRSxVSoxG+2jthO2ZDZNVCS6q X-Google-Smtp-Source: ABdhPJwAtrlk+4xfJhh48GTLeoCeohdKmJ8CEoVKH2zYdsQM7LHT16itLvMNHM2FrOQLj29OSvANkw== X-Received: by 2002:a05:600c:2299:: with SMTP id 25mr3171519wmf.138.1589536449567; Fri, 15 May 2020 02:54:09 -0700 (PDT) Received: from localhost.localdomain (cpc91192-cmbg18-2-0-cust374.5-4.cable.virginm.net. [80.6.113.119]) by smtp.gmail.com with ESMTPSA id s12sm2705817wmc.7.2020.05.15.02.54.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 02:54:09 -0700 (PDT) From: Emil Velikov To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 07/38] drm/amdgpu: use the unlocked drm_gem_object_put Date: Fri, 15 May 2020 10:50:47 +0100 Message-Id: <20200515095118.2743122-8-emil.l.velikov@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200515095118.2743122-1-emil.l.velikov@gmail.com> References: <20200515095118.2743122-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Deucher , emil.l.velikov@gmail.com, =?utf-8?q?Christian_K=C3=B6nig?= , amd-gfx@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Emil Velikov The driver does not hold struct_mutex, thus using the locked version of the helper is incorrect. Cc: Alex Deucher Cc: Christian König Cc: amd-gfx@lists.freedesktop.org Fixes: a39414716ca0 ("drm/amdgpu: add independent DMA-buf import v9"): Signed-off-by: Emil Velikov Acked-by: Sam Ravnborg Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c index 43d8ed7dbd00..652c57a3b847 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c @@ -587,7 +587,7 @@ struct drm_gem_object *amdgpu_gem_prime_import(struct drm_device *dev, attach = dma_buf_dynamic_attach(dma_buf, dev->dev, &amdgpu_dma_buf_attach_ops, obj); if (IS_ERR(attach)) { - drm_gem_object_put(obj); + drm_gem_object_put_unlocked(obj); return ERR_CAST(attach); }