diff mbox series

drm/tidss: fix modeset init for DPI panels

Message ID 20200604080214.107159-1-tomi.valkeinen@ti.com (mailing list archive)
State New, archived
Headers show
Series drm/tidss: fix modeset init for DPI panels | expand

Commit Message

Tomi Valkeinen June 4, 2020, 8:02 a.m. UTC
The connector type for DISPC's DPI videoport was set the LVDS instead of
DPI. This causes any DPI panel setup to fail with tidss, making all DPI
panels unusable.

Fix this by using correct connector type.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Fixes: 32a1795f57eecc39749017 ("drm/tidss: New driver for TI Keystone platform Display SubSystem")
Cc: stable@vger.kernel.org # v5.7+
---
 drivers/gpu/drm/tidss/tidss_kms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jyri Sarha June 4, 2020, 9:09 a.m. UTC | #1
On 04/06/2020 11:02, Tomi Valkeinen wrote:
> The connector type for DISPC's DPI videoport was set the LVDS instead of
> DPI. This causes any DPI panel setup to fail with tidss, making all DPI
> panels unusable.
> 
> Fix this by using correct connector type.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Fixes: 32a1795f57eecc39749017 ("drm/tidss: New driver for TI Keystone platform Display SubSystem")
> Cc: stable@vger.kernel.org # v5.7+

Reviewed-by: Jyri Sarha <jsarha@ti.com>

> ---
>  drivers/gpu/drm/tidss/tidss_kms.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c
> index 7d419960b030..74467f6eafee 100644
> --- a/drivers/gpu/drm/tidss/tidss_kms.c
> +++ b/drivers/gpu/drm/tidss/tidss_kms.c
> @@ -154,7 +154,7 @@ static int tidss_dispc_modeset_init(struct tidss_device *tidss)
>  				break;
>  			case DISPC_VP_DPI:
>  				enc_type = DRM_MODE_ENCODER_DPI;
> -				conn_type = DRM_MODE_CONNECTOR_LVDS;
> +				conn_type = DRM_MODE_CONNECTOR_DPI;
>  				break;
>  			default:
>  				WARN_ON(1);
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c
index 7d419960b030..74467f6eafee 100644
--- a/drivers/gpu/drm/tidss/tidss_kms.c
+++ b/drivers/gpu/drm/tidss/tidss_kms.c
@@ -154,7 +154,7 @@  static int tidss_dispc_modeset_init(struct tidss_device *tidss)
 				break;
 			case DISPC_VP_DPI:
 				enc_type = DRM_MODE_ENCODER_DPI;
-				conn_type = DRM_MODE_CONNECTOR_LVDS;
+				conn_type = DRM_MODE_CONNECTOR_DPI;
 				break;
 			default:
 				WARN_ON(1);