| Message ID | 20200616145452.GA25291@embeddedor (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] drm/i915/selftests: Fix inconsistent IS_ERR and PTR_ERR | expand |
Quoting Gustavo A. R. Silva (2020-06-16 15:54:52) > Fix inconsistent IS_ERR and PTR_ERR in live_timeslice_nopreempt(). > > The proper pointer to be passed as argument to PTR_ERR() is ce. > > This bug was detected with the help of Coccinelle. > > Fixes: b72f02d78e4f ("drm/i915/gt: Prevent timeslicing into unpreemptable requests") > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Fair enough, I had sent out a patch that included this, but never split it out for early adoption. Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c index 91543494f595..393339de0910 100644 --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c @@ -1337,7 +1337,7 @@ static int live_timeslice_nopreempt(void *arg) ce = intel_context_create(engine); if (IS_ERR(ce)) { - err = PTR_ERR(rq); + err = PTR_ERR(ce); goto out_spin; }
Fix inconsistent IS_ERR and PTR_ERR in live_timeslice_nopreempt(). The proper pointer to be passed as argument to PTR_ERR() is ce. This bug was detected with the help of Coccinelle. Fixes: b72f02d78e4f ("drm/i915/gt: Prevent timeslicing into unpreemptable requests") Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)