From patchwork Sat Jun 27 07:03:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Boichat X-Patchwork-Id: 11629253 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B1CD2618 for ; Sat, 27 Jun 2020 07:03:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9091D2088E for ; Sat, 27 Jun 2020 07:03:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="htgSWoZY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9091D2088E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 742F16E53E; Sat, 27 Jun 2020 07:03:50 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F2A36E53C for ; Sat, 27 Jun 2020 07:03:49 +0000 (UTC) Received: by mail-pg1-x542.google.com with SMTP id d4so5989297pgk.4 for ; Sat, 27 Jun 2020 00:03:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JIosRsYUTOshrLf9E2nl2GJ34SluYbFrDfjI2qfYIOA=; b=htgSWoZYFY6WcBXOQK9T5GXxNKi9tWAhW/nWYQX+1VSb2mWxW60jVVTDudnPYYxYg9 Db6tG7Ov5zFbEDNBHh0QL03Icg3P8mr9lEp3yBXgjy9GRdC0fzW55NbLo/Orks5+Th4M IwjLLTam86gpjv8tJjNMO8NPqPOfgkTp1JTSc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JIosRsYUTOshrLf9E2nl2GJ34SluYbFrDfjI2qfYIOA=; b=HUOtEvOs8YEriiqZe5/tvwOQW81RqvGbRRysDJL7MHei1XM7MFkzMLECAAsXRjm70c s7uBrbN2RtxZ79Coh6vQBV4YMJMmZKOtWgS8uaq4R74SzRROWRk6HC2GbQkikIefbVL1 ubiDtKQW003PvP/a1Gg07Kn4wRltjN6GT4K69suGdNsqqAzHS9VvVYKf8pBB0Jf9Nwje x9nVJEbQaLJvGcs2HiR8bCKwBb8XjodmnRXhrU0vUh8/357kqD8VWBrqIR0gByEInivx FXFIzrdJ/fyyhHzpGDaCWKjFX0TZwuJWopwr67iJ/TbFS6AmIfaXeDaMgInbFP2joibk dnkQ== X-Gm-Message-State: AOAM5309tIsQVEihJWBC0/D6zeViWfqI+TXuLDkf/OVcHah1VA0xLKVi dOniWFtRT0m2Znu97pZ6LqN4og== X-Google-Smtp-Source: ABdhPJxZ3PtR4eUISGAgJy894bXe43kXGpa3zCIO5LeduT92f8pdNbMpmZcrSYZMCYcAKlBhZ72tJg== X-Received: by 2002:a63:6442:: with SMTP id y63mr2132897pgb.18.1593241428951; Sat, 27 Jun 2020 00:03:48 -0700 (PDT) Received: from drinkcat2.tpe.corp.google.com ([2401:fa00:1:b:d8b7:33af:adcb:b648]) by smtp.gmail.com with ESMTPSA id u4sm28133269pfl.102.2020.06.27.00.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Jun 2020 00:03:48 -0700 (PDT) From: Nicolas Boichat To: linux-kernel@vger.kernel.org Subject: [PATCH 3/4] media: camss: vfe: Use trace_printk for debugging only Date: Sat, 27 Jun 2020 15:03:06 +0800 Message-Id: <20200627070307.516803-4-drinkcat@chromium.org> X-Mailer: git-send-email 2.27.0.212.ge8ba1cc988-goog In-Reply-To: <20200627070307.516803-1-drinkcat@chromium.org> References: <20200627070307.516803-1-drinkcat@chromium.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Chen , "Guilherme G . Piccoli" , Rafael Aquini , Sam Ravnborg , David Airlie , Todor Tomov , Bjorn Andersson , David Howells , Tiezhu Yang , Will Deacon , Christian Brauner , Kees Cook , devel@driverdev.osuosl.org, Stephen Rothwell , Nicolas Boichat , Jayshri Pawar , Masahiro Yamada , Alexei Starovoitov , Jason Gunthorpe , Andy Gross , Tomas Winkler , Alexey Dobriyan , linux-media@vger.kernel.org, Pawel Laszczak , Arnd Bergmann , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, Chao Yu , Steven Rostedt , Rodrigo Vivi , Jaegeuk Kim , Thomas Gleixner , Mauro Carvalho Chehab , Ingo Molnar , Roger Quadros , Felipe Balbi , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Andy Shevchenko , Sakari Ailus , Colin Ian King , Andrew Morton , Divya Indi Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" trace_printk should not be used in production code. Since tracing interrupts is presumably latency sensitive, pr_dbg is not appropriate, so guard the call with a preprocessor symbol that can be defined for debugging purpose. Signed-off-by: Nicolas Boichat --- drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 2 ++ drivers/media/platform/qcom/camss/camss-vfe-4-7.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c index 174a36be6f5d866..0c57171fae4f9e9 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c @@ -936,8 +936,10 @@ static irqreturn_t vfe_isr(int irq, void *dev) vfe->ops->isr_read(vfe, &value0, &value1); +#ifdef CAMSS_VFE_TRACE_IRQ trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n", value0, value1); +#endif if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK) vfe->isr_ops.reset_ack(vfe); diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c index 0dca8bf9281e774..307675925e5c779 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c @@ -1058,8 +1058,10 @@ static irqreturn_t vfe_isr(int irq, void *dev) vfe->ops->isr_read(vfe, &value0, &value1); +#ifdef CAMSS_VFE_TRACE_IRQ trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n", value0, value1); +#endif if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK) vfe->isr_ops.reset_ack(vfe);