From patchwork Tue Aug 18 21:05:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 11722157 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A989316B1 for ; Tue, 18 Aug 2020 21:05:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 896F520786 for ; Tue, 18 Aug 2020 21:05:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=poorly.run header.i=@poorly.run header.b="BIuERJfo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 896F520786 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=poorly.run Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9AC1A6E176; Tue, 18 Aug 2020 21:05:38 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by gabe.freedesktop.org (Postfix) with ESMTPS id 865036E159 for ; Tue, 18 Aug 2020 21:05:29 +0000 (UTC) Received: by mail-qt1-x842.google.com with SMTP id t23so16272535qto.3 for ; Tue, 18 Aug 2020 14:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4Jm090YO1+7FHoZ4sEUb6h6tQUSUe1qBtD8vovVHheQ=; b=BIuERJfoHAy4W0RJt9ym3MaPNXjYJxlLvZp5rXjzwEqyUCb4UTlXEYpfhtfrwtbStx 57+FHZo17bUwUj9sTLrPmAVHKM3hxdj4wr2XVYGcnZjYXdO7KmQHJf6qbz3gB/D3TyIH 1FwydMt3EDMQfwECrD0UOX5K6UNJCsQtvUvJFQzdoXuQCY5s6W0wd/+H91HHOXcwgG0Z bM/aBehQlv2hso2Wxgc6O9Kyfx0cHeVW/hm7Wq4qYJtAYOpYbH9E4nYGPxCYl6eImdGa WzzyfuJuojQbNVmvzLSTWnXm1EwOR+Qh+CLgf93LWP0Zkltq9/CWkyWavuXbasqd7fJ8 yDdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4Jm090YO1+7FHoZ4sEUb6h6tQUSUe1qBtD8vovVHheQ=; b=Ud1pflS+4O0aRBhKAbIp4K/6OLWWoMrqKpX2x7xe17H6dLaHaBUdPdXJIJQHLtucA9 33/BY5acPzxCNgKT7oNHUu7MLfwbbnT+q9Ww1skFMozp3d2Iq9AgISLYOz8EcrXGAjGN GFUFr5qZ+VpcCBAdP9siRXz/IJcU5G9MbONfGZ5ho2goVtVidaHLqC2OxKgG+0uqAcrh ju7iVoyqS1IVfj27Yy2ZXocZl16edr4+eiwfUZhvTqTSoutwzJyNPIBpEkcmsWYVsvAW 7oXPa0VSGA0P1WGWuq9Z+DXVpLBMPhnWK0J7aVEVWO23xEjC2np68MJSCpLC62K8wmmJ ylFg== X-Gm-Message-State: AOAM530q7liQEfTChYqB+yyQXv7dDfcBmHLhzygNiGwHc9O659+NGJz1 WgaAlbZ+PGmf7OjUr2qLnjY3ClAFL94yxQ== X-Google-Smtp-Source: ABdhPJwLf3rAmtoKhmRGtIOjr48woa6GEjQtQQB79JdFPv1Mc+dhngPPiaTi4tia7I0yvfyPnaEHJg== X-Received: by 2002:aed:2542:: with SMTP id w2mr20474156qtc.272.1597784728452; Tue, 18 Aug 2020 14:05:28 -0700 (PDT) Received: from localhost (mobile-166-177-184-140.mycingular.net. [166.177.184.140]) by smtp.gmail.com with ESMTPSA id m26sm26847712qtc.83.2020.08.18.14.05.27 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Aug 2020 14:05:28 -0700 (PDT) From: Sean Paul To: dri-devel@lists.freedesktop.org, ppaalanen@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, seanpaul@chromium.org, airlied@linux.ie Subject: [PATCH v6 06/14] drm/amd: Gate i2c transaction logs on drm_debug_syslog Date: Tue, 18 Aug 2020 17:05:02 -0400 Message-Id: <20200818210510.49730-7-sean@poorly.run> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200818210510.49730-1-sean@poorly.run> References: <20200818210510.49730-1-sean@poorly.run> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.vetter@ffwll.ch Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Sean Paul Since the logs protected by these checks specifically target syslog, use the new drm_debug_syslog_enabled() call to avoid triggering these prints when only trace is enabled. Acked-by: Christian König Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-7-sean@poorly.run #v5 Changes in v5: -Added to the set Changes in v6: -None --- drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c b/drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c index d55bf64770c4..1600a007344b 100644 --- a/drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c +++ b/drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c @@ -232,7 +232,7 @@ static uint32_t smu_v11_0_i2c_transmit(struct i2c_adapter *control, DRM_DEBUG_DRIVER("I2C_Transmit(), address = %x, bytes = %d , data: ", (uint16_t)address, numbytes); - if (drm_debug_enabled(DRM_UT_DRIVER)) { + if (drm_debug_syslog_enabled(DRM_UT_DRIVER)) { print_hex_dump(KERN_INFO, "data: ", DUMP_PREFIX_NONE, 16, 1, data, numbytes, false); } @@ -386,7 +386,7 @@ static uint32_t smu_v11_0_i2c_receive(struct i2c_adapter *control, DRM_DEBUG_DRIVER("I2C_Receive(), address = %x, bytes = %d, data :", (uint16_t)address, bytes_received); - if (drm_debug_enabled(DRM_UT_DRIVER)) { + if (drm_debug_syslog_enabled(DRM_UT_DRIVER)) { print_hex_dump(KERN_INFO, "data: ", DUMP_PREFIX_NONE, 16, 1, data, bytes_received, false); }