| Message ID | 20200912033843.143240-1-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: analogix_dp: make analogix_dp_start_aux_transaction() static | expand |
ping... 在 2020/9/12 11:38, Jason Yan 写道: > This eliminates the following sparse warning: > > drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c:527:5: warning: symbol > 'analogix_dp_start_aux_transaction' was not declared. Should it be > static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Jason Yan <yanaijie@huawei.com> > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > index 914c569ab8c1..fafb4b492ea0 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > @@ -524,7 +524,7 @@ void analogix_dp_enable_sw_function(struct analogix_dp_device *dp) > writel(reg, dp->reg_base + ANALOGIX_DP_FUNC_EN_1); > } > > -int analogix_dp_start_aux_transaction(struct analogix_dp_device *dp) > +static int analogix_dp_start_aux_transaction(struct analogix_dp_device *dp) > { > int reg; > int retval = 0; >
Hi Jason. Thanks, also applied to drm-misc-next. If you had other drm/fbdev related patches pending then I have missed them so please resend. Sam On Sat, Sep 12, 2020 at 11:38:43AM +0800, Jason Yan wrote: > This eliminates the following sparse warning: > > drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c:527:5: warning: symbol > 'analogix_dp_start_aux_transaction' was not declared. Should it be > static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Jason Yan <yanaijie@huawei.com> > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > index 914c569ab8c1..fafb4b492ea0 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > @@ -524,7 +524,7 @@ void analogix_dp_enable_sw_function(struct analogix_dp_device *dp) > writel(reg, dp->reg_base + ANALOGIX_DP_FUNC_EN_1); > } > > -int analogix_dp_start_aux_transaction(struct analogix_dp_device *dp) > +static int analogix_dp_start_aux_transaction(struct analogix_dp_device *dp) > { > int reg; > int retval = 0; > -- > 2.25.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c index 914c569ab8c1..fafb4b492ea0 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c @@ -524,7 +524,7 @@ void analogix_dp_enable_sw_function(struct analogix_dp_device *dp) writel(reg, dp->reg_base + ANALOGIX_DP_FUNC_EN_1); } -int analogix_dp_start_aux_transaction(struct analogix_dp_device *dp) +static int analogix_dp_start_aux_transaction(struct analogix_dp_device *dp) { int reg; int retval = 0;
This eliminates the following sparse warning: drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c:527:5: warning: symbol 'analogix_dp_start_aux_transaction' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)