From patchwork Fri Oct 16 07:12:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 11840981 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33E0EC433E7 for ; Fri, 16 Oct 2020 07:13:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A490620720 for ; Fri, 16 Oct 2020 07:13:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Adc8hCSg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A490620720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A30D76EA7C; Fri, 16 Oct 2020 07:13:04 +0000 (UTC) Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9846E6EA7C for ; Fri, 16 Oct 2020 07:13:03 +0000 (UTC) Received: by mail-pg1-x543.google.com with SMTP id l18so893697pgg.0 for ; Fri, 16 Oct 2020 00:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=cCtw9OFU3rtww1isHIEEcnmW7Zwg3NtpL46BN8HaGKc=; b=Adc8hCSgfLi+wo8dAry+ZnREP8hg6NKFlr+XNEwqPKajYvpxKQhVsOd5tP2kpfAQml +J3Bd806sQHX6JTcFRy9yLio7Ya6pAZbEmK6uKv/S4wc9uNDKs8eVJcVB5he/tTtraiQ rhsCxG0ulP5RpsrM+Cup+250sJp5/IokycFqtXeAkHsygkZKudrIIFDqyGL0tPE03ORJ lTNbIVo1kdnPVvdjlf27mwvet59zMLXO+yGsONs2kLFBak0rHRp7zDaTSJkwIKEbBWBa AXSrGEHT5lgODcGoDf4bherpayhmXVPlzT9wePWtPNx3QiYXJBRnMuyJfvaAnJ1kiIJv WdUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cCtw9OFU3rtww1isHIEEcnmW7Zwg3NtpL46BN8HaGKc=; b=d1xEmuGQgqYNSRJhTORIm/1hFOoi4ZBiJUWuhpaEC4WRFYkLYVTt1TMw89xSLSbvGv WCDPByaZH1gdJ8BAkhA4Y3Ql6AD2+3M94oGr1s65uvdKcLKIQZQhLFeUL3HJTrzHpLF4 tcoyBPXplyzbd6qziUuqTq1fmzLPakRMOf80w2GMOT2iiscqgCOyIZ+hjyYxpshMaSMn oQM38pKPk5KM8yfMwqC48mUYj4eXuFLFPS3Mbp0LjgJ7aFhpoPOaF8K0bFBYrc0ZHGNY YmZnDySwYkg80qb3IJVUWWkad3hG1Dqd93PORvyqdmV21sCCHa8OB+FCEKv6AyilBEH2 Zn8g== X-Gm-Message-State: AOAM533AEacSlRgz1GN7g9XFF3S6ZCFx1DIVx/BKeV7+Zkn2YZjePNBr IbMVGptzngsV3ozeG888IKackh4aQD39g1KP X-Google-Smtp-Source: ABdhPJxapsdkf6Bqbk4m3qu2DLLW+LOHCSF3toDzudWRrZr9o+8tN8TAButTAjC9xkFWvDDdKMInzA== X-Received: by 2002:a63:c70c:: with SMTP id n12mr1972958pgg.102.1602832382907; Fri, 16 Oct 2020 00:13:02 -0700 (PDT) Received: from localhost.localdomain (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id 14sm1479977pfy.192.2020.10.16.00.13.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2020 00:13:02 -0700 (PDT) From: Shawn Guo To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing Date: Fri, 16 Oct 2020 15:12:54 +0800 Message-Id: <20201016071254.2681-1-shawn.guo@linaro.org> X-Mailer: git-send-email 2.17.1 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , Sean Paul MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Commit 5caa0feafcc6 ("drm/vblank: Lock down vblank->hwmode more") added WARN_ON_ONCE() for atomic drivers to warn the case that vsync is enabled before a mode has been set on CRTC. This happens sometimes during the initial mode setting of a CRTC. It also happens on Android running HWC2 backed with drm_hwcomposer, where HWC2::SetVsyncEnabled could be called before the atomic mode setting on CRTC happens. In this case, there is nothing really bad to happen as kernel function returns as no-op. So using WARN() version might be overkilled, considering some user space crash reporting services may treat kernel WARNINGS as crashes. Let's drop WARN_ON_ONCE() and change drm_dbg_core() to drm_warn_once() for warning undefined mode timing. Signed-off-by: Shawn Guo --- drivers/gpu/drm/drm_vblank.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c index b18e1efbbae1..5f7c4a923e8a 100644 --- a/drivers/gpu/drm/drm_vblank.c +++ b/drivers/gpu/drm/drm_vblank.c @@ -717,9 +717,9 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal( * Happens during initial modesetting of a crtc. */ if (mode->crtc_clock == 0) { - drm_dbg_core(dev, "crtc %u: Noop due to uninitialized mode.\n", - pipe); - drm_WARN_ON_ONCE(dev, drm_drv_uses_atomic_modeset(dev)); + drm_warn_once(dev, "crtc %u: Noop due to uninitialized mode.\n", + pipe); + return false; }