| Message ID | 20201023122216.2373294-1-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/65] drm/vc4: Drop legacy_cursor_update override | expand |
On Fri, Oct 23, 2020 at 02:21:12PM +0200, Daniel Vetter wrote: > With the removal of helper support it doesn't do anything anymore. > Also, we already have async plane update code in vc4. > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Eric Anholt <eric@anholt.net> > Cc: Maxime Ripard <mripard@kernel.org> Apologies for this patch bomb, typoed git send-email command. -Daniel > --- > drivers/gpu/drm/vc4/vc4_kms.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c > index 149825ff5df8..bf0da77ab2e6 100644 > --- a/drivers/gpu/drm/vc4/vc4_kms.c > +++ b/drivers/gpu/drm/vc4/vc4_kms.c > @@ -353,12 +353,6 @@ static int vc4_atomic_commit(struct drm_device *dev, > return 0; > } > > - /* We know for sure we don't want an async update here. Set > - * state->legacy_cursor_update to false to prevent > - * drm_atomic_helper_setup_commit() from auto-completing > - * commit->flip_done. > - */ > - state->legacy_cursor_update = false; > ret = drm_atomic_helper_setup_commit(state, nonblock); > if (ret) > return ret; > -- > 2.28.0 >
diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c index 149825ff5df8..bf0da77ab2e6 100644 --- a/drivers/gpu/drm/vc4/vc4_kms.c +++ b/drivers/gpu/drm/vc4/vc4_kms.c @@ -353,12 +353,6 @@ static int vc4_atomic_commit(struct drm_device *dev, return 0; } - /* We know for sure we don't want an async update here. Set - * state->legacy_cursor_update to false to prevent - * drm_atomic_helper_setup_commit() from auto-completing - * commit->flip_done. - */ - state->legacy_cursor_update = false; ret = drm_atomic_helper_setup_commit(state, nonblock); if (ret) return ret;
With the removal of helper support it doesn't do anything anymore. Also, we already have async plane update code in vc4. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Eric Anholt <eric@anholt.net> Cc: Maxime Ripard <mripard@kernel.org> --- drivers/gpu/drm/vc4/vc4_kms.c | 6 ------ 1 file changed, 6 deletions(-)