From patchwork Fri Oct 23 12:39:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11853351 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EC0DC388F9 for ; Fri, 23 Oct 2020 12:39:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1764208C3 for ; Fri, 23 Oct 2020 12:39:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="cIiVlFPM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1764208C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9C8626F64E; Fri, 23 Oct 2020 12:39:34 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5CDF56F875 for ; Fri, 23 Oct 2020 12:39:33 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id t9so1618051wrq.11 for ; Fri, 23 Oct 2020 05:39:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PGEKwn6M9eko3KN/fzTkRc1z8KxmYtWMP0qrwYX/alg=; b=cIiVlFPMyq3bo3bTzWHFm2wxUwLPGAJ95lFXtpkG7HuLE3NSES2nceiPcSSwB4dbqH oHT7dPIuKZvj9Pg2nFIuj7Pdtzya4KT+OWfnglmKFZnYD3aO6tDZSDWk6QJo7XjWBcI1 i80ahkHRr4QJjp7N8fSM377apfJdawTkeK7js= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PGEKwn6M9eko3KN/fzTkRc1z8KxmYtWMP0qrwYX/alg=; b=p8EA/Y+Cn3dk3Mq6BrjE0j8zhmNseyAezRnTGROXo+mtVNs16eN5DWQFWV6779WKtq VB170xWFTbaH0vLlTeapDCJUnhJVoYjoxmh9BdcgC0xpNyt2GEZc76VWCdWCBm88cxEO Ws6bSMGG/XOdsjimc4V28woosU3X+VMLSqwyXcFLvjpzZLKg4Gl+5f+oRdMedSmtrbOB ZOzKbZl4hEUBbNBBcPDwXwb8fLYMOIMMn77mL7GHJONSVK7LfeOhUENWEhGmPPL0WWYr +ckrsYZ2nYn+2HRAkG/srha1P1XjCY2PUNhud5lXDSIL50QmO2DpP7R3Q5uIB4bUktk2 n/lA== X-Gm-Message-State: AOAM533C0FifZWGPAQd6ZQgClmYsDr8hJNX5WM8E3xsht8A+PE9j8crp 5AvvqBMYrIAHLw6RmPuy66fp3w2seABPZwwm X-Google-Smtp-Source: ABdhPJz/PhUu+t/aX5G/Cmsm+zg+bBHfzem38LjjBD1fJ5nh4ZQ24gZbtRqGyRFbvbs6SiAd7xq1wg== X-Received: by 2002:adf:f101:: with SMTP id r1mr2584805wro.392.1603456771835; Fri, 23 Oct 2020 05:39:31 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id 133sm3286462wmb.2.2020.10.23.05.39.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2020 05:39:31 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 2/3] drm/vc4: Drop legacy_cursor_update override Date: Fri, 23 Oct 2020 14:39:24 +0200 Message-Id: <20201023123925.2374863-2-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201023123925.2374863-1-daniel.vetter@ffwll.ch> References: <20201023123925.2374863-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" With the removal of helper support it doesn't do anything anymore. Also, we already have async plane update code in vc4. Acked-by: Maxime Ripard Signed-off-by: Daniel Vetter Cc: Eric Anholt Cc: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_kms.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c index 149825ff5df8..bf0da77ab2e6 100644 --- a/drivers/gpu/drm/vc4/vc4_kms.c +++ b/drivers/gpu/drm/vc4/vc4_kms.c @@ -353,12 +353,6 @@ static int vc4_atomic_commit(struct drm_device *dev, return 0; } - /* We know for sure we don't want an async update here. Set - * state->legacy_cursor_update to false to prevent - * drm_atomic_helper_setup_commit() from auto-completing - * commit->flip_done. - */ - state->legacy_cursor_update = false; ret = drm_atomic_helper_setup_commit(state, nonblock); if (ret) return ret;