| Message ID | 20201027164208.10026-14-anshuman.gupta@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | HDCP 2.2 and HDCP 1.4 Gen12 DP MST support | expand |
On 2020-10-27 at 22:12:05 +0530, Anshuman Gupta wrote: > This requires for HDCP 2.2 MST check link. > > Cc: Ramalingam C <ramalingam.c@intel.com> > Reviewed-by: Uma Shankar <uma.shankar@intel.com> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > --- > drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++- > drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 3 ++- > drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- > drivers/gpu/drm/i915/display/intel_hdmi.c | 3 ++- > 4 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h > index 24e0067c2e7c..dfb5be64e03a 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_types.h > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h > @@ -375,7 +375,8 @@ struct intel_hdcp_shim { > bool is_repeater, u8 type); > > /* HDCP2.2 Link Integrity Check */ > - int (*check_2_2_link)(struct intel_digital_port *dig_port); > + int (*check_2_2_link)(struct intel_digital_port *dig_port, > + struct intel_connector *connector); do we need both of them? -Ram. > }; > > struct intel_hdcp { > diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > index 591b68e5de48..4be61e7fde4e 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > @@ -585,7 +585,8 @@ int intel_dp_hdcp2_config_stream_type(struct intel_digital_port *dig_port, > } > > static > -int intel_dp_hdcp2_check_link(struct intel_digital_port *dig_port) > +int intel_dp_hdcp2_check_link(struct intel_digital_port *dig_port, > + struct intel_connector *connector) > { > u8 rx_status; > int ret; > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c > index 1df6d4a23476..87f7aaf3a319 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdcp.c > +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c > @@ -1940,7 +1940,7 @@ static int intel_hdcp2_check_link(struct intel_connector *connector) > goto out; > } > > - ret = hdcp->shim->check_2_2_link(dig_port); > + ret = hdcp->shim->check_2_2_link(dig_port, connector); > if (ret == HDCP_LINK_PROTECTED) { > if (hdcp->value != DRM_MODE_CONTENT_PROTECTION_UNDESIRED) { > intel_hdcp_update_value(connector, > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c > index 0788de04711b..bd0d91101464 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c > @@ -1734,7 +1734,8 @@ int intel_hdmi_hdcp2_read_msg(struct intel_digital_port *dig_port, > } > > static > -int intel_hdmi_hdcp2_check_link(struct intel_digital_port *dig_port) > +int intel_hdmi_hdcp2_check_link(struct intel_digital_port *dig_port, > + struct intel_connector *connector) > { > u8 rx_status[HDCP_2_2_HDMI_RXSTATUS_LEN]; > int ret; > -- > 2.26.2 >
On 2020-11-05 at 22:15:37 +0530, Ramalingam C wrote: > On 2020-10-27 at 22:12:05 +0530, Anshuman Gupta wrote: > > This requires for HDCP 2.2 MST check link. > > > > Cc: Ramalingam C <ramalingam.c@intel.com> > > Reviewed-by: Uma Shankar <uma.shankar@intel.com> > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++- > > drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 3 ++- > > drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- > > drivers/gpu/drm/i915/display/intel_hdmi.c | 3 ++- > > 4 files changed, 7 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h > > index 24e0067c2e7c..dfb5be64e03a 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display_types.h > > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h > > @@ -375,7 +375,8 @@ struct intel_hdcp_shim { > > bool is_repeater, u8 type); > > > > /* HDCP2.2 Link Integrity Check */ > > - int (*check_2_2_link)(struct intel_digital_port *dig_port); > > + int (*check_2_2_link)(struct intel_digital_port *dig_port, > > + struct intel_connector *connector); > do we need both of them? I have followed the HDCP 1.4 check_link signature. https://patchwork.freedesktop.org/patch/386157/?series=78749&rev=3 We need connector for QSES check, we can't retrieve DP MST connector from dig_port. Thanks, Anshuman > > -Ram. > > }; > > > > struct intel_hdcp { > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > > index 591b68e5de48..4be61e7fde4e 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > > @@ -585,7 +585,8 @@ int intel_dp_hdcp2_config_stream_type(struct intel_digital_port *dig_port, > > } > > > > static > > -int intel_dp_hdcp2_check_link(struct intel_digital_port *dig_port) > > +int intel_dp_hdcp2_check_link(struct intel_digital_port *dig_port, > > + struct intel_connector *connector) > > { > > u8 rx_status; > > int ret; > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c > > index 1df6d4a23476..87f7aaf3a319 100644 > > --- a/drivers/gpu/drm/i915/display/intel_hdcp.c > > +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c > > @@ -1940,7 +1940,7 @@ static int intel_hdcp2_check_link(struct intel_connector *connector) > > goto out; > > } > > > > - ret = hdcp->shim->check_2_2_link(dig_port); > > + ret = hdcp->shim->check_2_2_link(dig_port, connector); > > if (ret == HDCP_LINK_PROTECTED) { > > if (hdcp->value != DRM_MODE_CONTENT_PROTECTION_UNDESIRED) { > > intel_hdcp_update_value(connector, > > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c > > index 0788de04711b..bd0d91101464 100644 > > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c > > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c > > @@ -1734,7 +1734,8 @@ int intel_hdmi_hdcp2_read_msg(struct intel_digital_port *dig_port, > > } > > > > static > > -int intel_hdmi_hdcp2_check_link(struct intel_digital_port *dig_port) > > +int intel_hdmi_hdcp2_check_link(struct intel_digital_port *dig_port, > > + struct intel_connector *connector) > > { > > u8 rx_status[HDCP_2_2_HDMI_RXSTATUS_LEN]; > > int ret; > > -- > > 2.26.2 > >
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h index 24e0067c2e7c..dfb5be64e03a 100644 --- a/drivers/gpu/drm/i915/display/intel_display_types.h +++ b/drivers/gpu/drm/i915/display/intel_display_types.h @@ -375,7 +375,8 @@ struct intel_hdcp_shim { bool is_repeater, u8 type); /* HDCP2.2 Link Integrity Check */ - int (*check_2_2_link)(struct intel_digital_port *dig_port); + int (*check_2_2_link)(struct intel_digital_port *dig_port, + struct intel_connector *connector); }; struct intel_hdcp { diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c index 591b68e5de48..4be61e7fde4e 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c @@ -585,7 +585,8 @@ int intel_dp_hdcp2_config_stream_type(struct intel_digital_port *dig_port, } static -int intel_dp_hdcp2_check_link(struct intel_digital_port *dig_port) +int intel_dp_hdcp2_check_link(struct intel_digital_port *dig_port, + struct intel_connector *connector) { u8 rx_status; int ret; diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c index 1df6d4a23476..87f7aaf3a319 100644 --- a/drivers/gpu/drm/i915/display/intel_hdcp.c +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c @@ -1940,7 +1940,7 @@ static int intel_hdcp2_check_link(struct intel_connector *connector) goto out; } - ret = hdcp->shim->check_2_2_link(dig_port); + ret = hdcp->shim->check_2_2_link(dig_port, connector); if (ret == HDCP_LINK_PROTECTED) { if (hdcp->value != DRM_MODE_CONTENT_PROTECTION_UNDESIRED) { intel_hdcp_update_value(connector, diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index 0788de04711b..bd0d91101464 100644 --- a/drivers/gpu/drm/i915/display/intel_hdmi.c +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c @@ -1734,7 +1734,8 @@ int intel_hdmi_hdcp2_read_msg(struct intel_digital_port *dig_port, } static -int intel_hdmi_hdcp2_check_link(struct intel_digital_port *dig_port) +int intel_hdmi_hdcp2_check_link(struct intel_digital_port *dig_port, + struct intel_connector *connector) { u8 rx_status[HDCP_2_2_HDMI_RXSTATUS_LEN]; int ret;