diff mbox series

drm/ast: Support 1600x900 with 108MHz PCLK

Message ID 20201030074212.22401-1-kuohsiang_chou@aspeedtech.com
State New, archived
Headers show
Series drm/ast: Support 1600x900 with 108MHz PCLK | expand

Commit Message

KuoHsiang Chou Oct. 30, 2020, 7:42 a.m. UTC
[New] Create the setting for 1600x900 @60Hz refresh rate
      by 108MHz pixel-clock.

Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>
---
 drivers/gpu/drm/ast/ast_tables.h | 2 ++
 1 file changed, 2 insertions(+)

--
2.18.4

Comments

Sam Ravnborg Nov. 1, 2020, 9:19 a.m. UTC | #1
Hi KuoHsiang

On Fri, Oct 30, 2020 at 03:42:12PM +0800, KuoHsiang Chou wrote:
> [New] Create the setting for 1600x900 @60Hz refresh rate
>       by 108MHz pixel-clock.
> 
> Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>

Thomas Zimmermann <tzimmermann@suse.de> is listed as reviewer
in MAINTAINERS, so included him in the list of receiver.
get_maintainer.pl should have told you that.

	Sam

> ---
>  drivers/gpu/drm/ast/ast_tables.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/ast/ast_tables.h b/drivers/gpu/drm/ast/ast_tables.h
> index d665dd5af5dd..8414e543f260 100644
> --- a/drivers/gpu/drm/ast/ast_tables.h
> +++ b/drivers/gpu/drm/ast/ast_tables.h
> @@ -282,6 +282,8 @@ static const struct ast_vbios_enhtable res_1360x768[] = {
>  };
> 
>  static const struct ast_vbios_enhtable res_1600x900[] = {
> +	{1800, 1600, 24, 80,1000,  900, 1, 3, VCLK108,		/* 60Hz */
> +	 (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 60, 3, 0x3A },
>  	{1760, 1600, 48, 32, 926, 900, 3, 5, VCLK97_75,		/* 60Hz CVT RB */
>  	 (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
>  	  AST2500PreCatchCRT), 60, 1, 0x3A },
> --
> 2.18.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
KuoHsiang Chou Nov. 2, 2020, 3:36 a.m. UTC | #2
Hi, Sam

Thanks for your teaching and the information got from v5.10-rc2 likes as

DRM DRIVER FOR AST SERVER GRAPHICS CHIPS
M:	Dave Airlie <airlied@redhat.com>
R:	Thomas Zimmermann <tzimmermann@suse.de>
L:	dri-devel@lists.freedesktop.org
S:	Supported
T:	git git://anongit.freedesktop.org/drm/drm-misc
F:	drivers/gpu/drm/ast/

Regards,
	Kuo-Hsiang Chou

-----Original Message-----
From: Sam Ravnborg [mailto:sam@ravnborg.org] 
Sent: Sunday, November 01, 2020 5:19 PM
To: Kuo-Hsiang Chou <kuohsiang_chou@aspeedtech.com>; Thomas Zimmermann <tzimmermann@suse.de>
Cc: dri-devel@lists.freedesktop.org; eich@suse.com; Tommy Huang <tommy_huang@aspeedtech.com>; Jenmin Yuan <jenmin_yuan@aspeedtech.com>; airlied@redhat.com; Arc Sung <arc_sung@aspeedtech.com>
Subject: Re: [PATCH] drm/ast: Support 1600x900 with 108MHz PCLK

Hi KuoHsiang

On Fri, Oct 30, 2020 at 03:42:12PM +0800, KuoHsiang Chou wrote:
> [New] Create the setting for 1600x900 @60Hz refresh rate
>       by 108MHz pixel-clock.
> 
> Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>

Thomas Zimmermann <tzimmermann@suse.de> is listed as reviewer in MAINTAINERS, so included him in the list of receiver.
get_maintainer.pl should have told you that.

	Sam

> ---
>  drivers/gpu/drm/ast/ast_tables.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/ast/ast_tables.h 
> b/drivers/gpu/drm/ast/ast_tables.h
> index d665dd5af5dd..8414e543f260 100644
> --- a/drivers/gpu/drm/ast/ast_tables.h
> +++ b/drivers/gpu/drm/ast/ast_tables.h
> @@ -282,6 +282,8 @@ static const struct ast_vbios_enhtable 
> res_1360x768[] = {  };
> 
>  static const struct ast_vbios_enhtable res_1600x900[] = {
> +	{1800, 1600, 24, 80,1000,  900, 1, 3, VCLK108,		/* 60Hz */
> +	 (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | 
> +NewModeInfo), 60, 3, 0x3A },
>  	{1760, 1600, 48, 32, 926, 900, 3, 5, VCLK97_75,		/* 60Hz CVT RB */
>  	 (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
>  	  AST2500PreCatchCRT), 60, 1, 0x3A },
> --
> 2.18.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Thomas Zimmermann Nov. 2, 2020, 7:57 a.m. UTC | #3
Hi

Am 30.10.20 um 08:42 schrieb KuoHsiang Chou:
> [New] Create the setting for 1600x900 @60Hz refresh rate
>       by 108MHz pixel-clock.
> 
> Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

I'll add your patch to drm-misc-next.

As Sam mentioned, you should use scripts/get_maintainers.pl to retrieve
the relevant people. These include those in MAINTAINERS, but also
developers that have previously worked on the code.

The easiest way is

  git format-patch <rev^1>...<rev>

which results in a patch file. Then do

  scripts/get_maintainers.pl <filename>

on the file. Please also run

  scripts/checkpatch.pl <filename>

on the file to get a report on potential errors.

Best regards
Thomas


> ---
>  drivers/gpu/drm/ast/ast_tables.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/ast/ast_tables.h b/drivers/gpu/drm/ast/ast_tables.h
> index d665dd5af5dd..8414e543f260 100644
> --- a/drivers/gpu/drm/ast/ast_tables.h
> +++ b/drivers/gpu/drm/ast/ast_tables.h
> @@ -282,6 +282,8 @@ static const struct ast_vbios_enhtable res_1360x768[] = {
>  };
> 
>  static const struct ast_vbios_enhtable res_1600x900[] = {
> +	{1800, 1600, 24, 80,1000,  900, 1, 3, VCLK108,		/* 60Hz */
> +	 (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 60, 3, 0x3A },
>  	{1760, 1600, 48, 32, 926, 900, 3, 5, VCLK97_75,		/* 60Hz CVT RB */
>  	 (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
>  	  AST2500PreCatchCRT), 60, 1, 0x3A },
> --
> 2.18.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/ast/ast_tables.h b/drivers/gpu/drm/ast/ast_tables.h
index d665dd5af5dd..8414e543f260 100644
--- a/drivers/gpu/drm/ast/ast_tables.h
+++ b/drivers/gpu/drm/ast/ast_tables.h
@@ -282,6 +282,8 @@  static const struct ast_vbios_enhtable res_1360x768[] = {
 };

 static const struct ast_vbios_enhtable res_1600x900[] = {
+	{1800, 1600, 24, 80,1000,  900, 1, 3, VCLK108,		/* 60Hz */
+	 (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 60, 3, 0x3A },
 	{1760, 1600, 48, 32, 926, 900, 3, 5, VCLK97_75,		/* 60Hz CVT RB */
 	 (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
 	  AST2500PreCatchCRT), 60, 1, 0x3A },