diff mbox series

[v3,3/3] dt-bindings: panel: common: Add reference to graph schema

Message ID 20201102203656.220187-4-robh@kernel.org (mailing list archive)
State New, archived
Headers show
Series dt-bindings: Convert graph bindings to json-schema | expand

Commit Message

Rob Herring (Arm) Nov. 2, 2020, 8:36 p.m. UTC
Now that we have a graph schema, reference it from the common panel
schema.

Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
v3: new patch

 .../devicetree/bindings/display/panel/panel-common.yaml    | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

--
2.25.1

Comments

Sam Ravnborg Nov. 5, 2020, 9:46 p.m. UTC | #1
On Mon, Nov 02, 2020 at 02:36:56PM -0600, Rob Herring wrote:
> Now that we have a graph schema, reference it from the common panel
> schema.
> 
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

I expect you to apply the patch due to the dependencies.
We can start using graph.yaml in drm-misc-next after the merge
window and a backmerge.

	Sam
Laurent Pinchart Nov. 11, 2020, 2:02 p.m. UTC | #2
Hi Rob,

Thank you for the patch.

On Mon, Nov 02, 2020 at 02:36:56PM -0600, Rob Herring wrote:
> Now that we have a graph schema, reference it from the common panel
> schema.
> 
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> v3: new patch
> 
>  .../devicetree/bindings/display/panel/panel-common.yaml    | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> index cd6dc5461721..a3a72c574213 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> @@ -68,16 +68,15 @@ properties:
> 
>    # Connectivity
>    port:
> -    type: object
> +    $ref: /schemas/graph.yaml#/properties/port
> 
>    ports:
> -    type: object
> +    $ref: /schemas/graph.yaml#/properties/ports
>      description:
>        Panels receive video data through one or multiple connections. While
>        the nature of those connections is specific to the panel type, the
>        connectivity is expressed in a standard fashion using ports as specified
> -      in the device graph bindings defined in
> -      Documentation/devicetree/bindings/graph.txt.
> +      in the device graph bindings.
> 
>    ddc-i2c-bus:
>      $ref: /schemas/types.yaml#/definitions/phandle
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
index cd6dc5461721..a3a72c574213 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
@@ -68,16 +68,15 @@  properties:

   # Connectivity
   port:
-    type: object
+    $ref: /schemas/graph.yaml#/properties/port

   ports:
-    type: object
+    $ref: /schemas/graph.yaml#/properties/ports
     description:
       Panels receive video data through one or multiple connections. While
       the nature of those connections is specific to the panel type, the
       connectivity is expressed in a standard fashion using ports as specified
-      in the device graph bindings defined in
-      Documentation/devicetree/bindings/graph.txt.
+      in the device graph bindings.

   ddc-i2c-bus:
     $ref: /schemas/types.yaml#/definitions/phandle