| Message ID | 20201106124224.21201-1-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/gma500: Remove unused function psb_gem_get_aperture() | expand |
On Fri, Nov 06, 2020 at 01:42:24PM +0100, Thomas Zimmermann wrote: > Apparently, the function was never used at all. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Indeed unused. I expect you or Patrik to apply the patch. Sam > --- > drivers/gpu/drm/gma500/gem.c | 6 ------ > drivers/gpu/drm/gma500/psb_drv.h | 2 -- > 2 files changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c > index 8f07de83b6fb..db827e591403 100644 > --- a/drivers/gpu/drm/gma500/gem.c > +++ b/drivers/gpu/drm/gma500/gem.c > @@ -32,12 +32,6 @@ static void psb_gem_free_object(struct drm_gem_object *obj) > psb_gtt_free_range(obj->dev, gtt); > } > > -int psb_gem_get_aperture(struct drm_device *dev, void *data, > - struct drm_file *file) > -{ > - return -EINVAL; > -} > - > static const struct vm_operations_struct psb_gem_vm_ops = { > .fault = psb_gem_fault, > .open = drm_gem_vm_open, > diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h > index c71a5a4e912c..ce6aae4b1bb2 100644 > --- a/drivers/gpu/drm/gma500/psb_drv.h > +++ b/drivers/gpu/drm/gma500/psb_drv.h > @@ -735,8 +735,6 @@ extern const struct drm_connector_helper_funcs > extern const struct drm_connector_funcs psb_intel_lvds_connector_funcs; > > /* gem.c */ > -extern int psb_gem_get_aperture(struct drm_device *dev, void *data, > - struct drm_file *file); > extern int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev, > struct drm_mode_create_dumb *args); > > -- > 2.29.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Fri, Nov 6, 2020 at 1:42 PM Thomas Zimmermann <tzimmermann@suse.de> wrote: > > Apparently, the function was never used at all. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Thanks Thomas, As agreed, please apply to drm-misc-next -Patrik > --- > drivers/gpu/drm/gma500/gem.c | 6 ------ > drivers/gpu/drm/gma500/psb_drv.h | 2 -- > 2 files changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c > index 8f07de83b6fb..db827e591403 100644 > --- a/drivers/gpu/drm/gma500/gem.c > +++ b/drivers/gpu/drm/gma500/gem.c > @@ -32,12 +32,6 @@ static void psb_gem_free_object(struct drm_gem_object *obj) > psb_gtt_free_range(obj->dev, gtt); > } > > -int psb_gem_get_aperture(struct drm_device *dev, void *data, > - struct drm_file *file) > -{ > - return -EINVAL; > -} > - > static const struct vm_operations_struct psb_gem_vm_ops = { > .fault = psb_gem_fault, > .open = drm_gem_vm_open, > diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h > index c71a5a4e912c..ce6aae4b1bb2 100644 > --- a/drivers/gpu/drm/gma500/psb_drv.h > +++ b/drivers/gpu/drm/gma500/psb_drv.h > @@ -735,8 +735,6 @@ extern const struct drm_connector_helper_funcs > extern const struct drm_connector_funcs psb_intel_lvds_connector_funcs; > > /* gem.c */ > -extern int psb_gem_get_aperture(struct drm_device *dev, void *data, > - struct drm_file *file); > extern int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev, > struct drm_mode_create_dumb *args); > > -- > 2.29.0 >
diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c index 8f07de83b6fb..db827e591403 100644 --- a/drivers/gpu/drm/gma500/gem.c +++ b/drivers/gpu/drm/gma500/gem.c @@ -32,12 +32,6 @@ static void psb_gem_free_object(struct drm_gem_object *obj) psb_gtt_free_range(obj->dev, gtt); } -int psb_gem_get_aperture(struct drm_device *dev, void *data, - struct drm_file *file) -{ - return -EINVAL; -} - static const struct vm_operations_struct psb_gem_vm_ops = { .fault = psb_gem_fault, .open = drm_gem_vm_open, diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h index c71a5a4e912c..ce6aae4b1bb2 100644 --- a/drivers/gpu/drm/gma500/psb_drv.h +++ b/drivers/gpu/drm/gma500/psb_drv.h @@ -735,8 +735,6 @@ extern const struct drm_connector_helper_funcs extern const struct drm_connector_funcs psb_intel_lvds_connector_funcs; /* gem.c */ -extern int psb_gem_get_aperture(struct drm_device *dev, void *data, - struct drm_file *file); extern int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev, struct drm_mode_create_dumb *args);
Apparently, the function was never used at all. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/gma500/gem.c | 6 ------ drivers/gpu/drm/gma500/psb_drv.h | 2 -- 2 files changed, 8 deletions(-)