From patchwork Fri Nov 13 13:49:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11903425 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67066C388F7 for ; Fri, 13 Nov 2020 13:50:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1905722201 for ; Fri, 13 Nov 2020 13:50:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oVPSe3gK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1905722201 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B8EC6E52C; Fri, 13 Nov 2020 13:49:59 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 070B76E52C for ; Fri, 13 Nov 2020 13:49:57 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id d142so8200018wmd.4 for ; Fri, 13 Nov 2020 05:49:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7u3R7+OjGQISbkuCs2m/TsCWsUoo+j2lw9OomX7FkgE=; b=oVPSe3gKajXzmTwgKcAiPMc6n66vSQUTIbxQGrlpz617vtWWaflWGSCujuQ8cnhsl8 Flp6j1U3fpCW7BBDGzKQP/99ib4s8fxs/3AQJXmBbOgVUYM9cW6lcnZJ6CnLvJKja8Ko d8CatTkf5GLBuTFXz+J+cf8WtmeIFmL5KsDnbuSwPcotT3zNcJ6w1GsXt+oCK9Lbw+nZ gm0psYuaDRRopbobUkafy6BIEHXJI+i+Eh5apV9e39CP9yF7cHUUGtaYNL6A+xjJB/xM 6gmjz6brGCBOeN1cuNZFWtroPbG536JOhvA1Fyspe4+AV4ymKme21mmgH9JPXwIC3zjR ZyPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7u3R7+OjGQISbkuCs2m/TsCWsUoo+j2lw9OomX7FkgE=; b=QQv1vpw5bGcLz5VSiiWYtUlKnqKlp0HJSlt0EI7KYj75db48hnvXjGJn33MIRoHb++ Avn9YSF49U52+JYJShUJu26uS8mjXnLRbyKpf3o7xAy+OLRQCYiDv2zMOt3nCsaRuTNh H0NY89LNpj61x/zxXIMbqxoaHCZx/XwUXmWXd5fyfHzGi8t0/8l7banmPUYV/BenZCia yiu8TK4fU17aROsY6Vj5zJ/V1/QqVnZhKSk2wu02Q77NauZ5zrj+Y7qgZvwti/XJhADO 0U8k0FOPPGI78Usdsvdg2v/T/rgL0TXF+kB1nrdKsSQLzVL5xrB8fvW6JkSJLpCPyvWF 5Xug== X-Gm-Message-State: AOAM532PK2KM/iN4cBE540zlWub1S+amkfsvIm1zunkRB2Z014AHGhf7 YN1N4aWr6sGmHPZFI8aos83Pmg== X-Google-Smtp-Source: ABdhPJxQxDqy7G7JaMskfG7ggUP9cLK1dW0ajER8rOj49sVwLKSqBc/GlSBicq1fC1nSz6FeOTHKOg== X-Received: by 2002:a1c:2cd7:: with SMTP id s206mr2531152wms.182.1605275395681; Fri, 13 Nov 2020 05:49:55 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id t11sm4561614wrm.8.2020.11.13.05.49.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2020 05:49:55 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 11/40] drm/amd/amdgpu/amdgpu_pll: Fix kernel-doc formatting, missing and extra params Date: Fri, 13 Nov 2020 13:49:09 +0000 Message-Id: <20201113134938.4004947-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201113134938.4004947-1-lee.jones@linaro.org> References: <20201113134938.4004947-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter or member 'freq' not described in 'amdgpu_pll_compute' drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter or member 'fb_div_p' not described in 'amdgpu_pll_compute' drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter or member 'frac_fb_div_p' not described in 'amdgpu_pll_compute' drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter or member 'ref_div_p' not described in 'amdgpu_pll_compute' drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter or member 'post_div_p' not described in 'amdgpu_pll_compute' drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:317: warning: Excess function parameter 'encoder' description in 'amdgpu_pll_get_shared_nondp_ppll' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c index 1f2305b7bd135..f2e20666c9c1b 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c @@ -102,11 +102,12 @@ static void amdgpu_pll_get_fb_ref_div(unsigned nom, unsigned den, unsigned post_ * amdgpu_pll_compute - compute PLL paramaters * * @pll: information about the PLL + * @freq: requested frequency * @dot_clock_p: resulting pixel clock - * fb_div_p: resulting feedback divider - * frac_fb_div_p: fractional part of the feedback divider - * ref_div_p: resulting reference divider - * post_div_p: resulting reference divider + * @fb_div_p: resulting feedback divider + * @frac_fb_div_p: fractional part of the feedback divider + * @ref_div_p: resulting reference divider + * @post_div_p: resulting reference divider * * Try to calculate the PLL parameters to generate the given frequency: * dot_clock = (ref_freq * feedback_div) / (ref_div * post_div) @@ -308,7 +309,6 @@ int amdgpu_pll_get_shared_dp_ppll(struct drm_crtc *crtc) * amdgpu_pll_get_shared_nondp_ppll - return the PPLL used by another non-DP crtc * * @crtc: drm crtc - * @encoder: drm encoder * * Returns the PPLL (Pixel PLL) used by another non-DP crtc/encoder which can * be shared (i.e., same clock).