diff mbox series

[12/40] drm/pl111/pl111_display: Make local function static

Message ID 20201113134938.4004947-13-lee.jones@linaro.org (mailing list archive)
State New, archived
Headers show
Series Rid W=1 warnings from GPU | expand

Commit Message

Lee Jones Nov. 13, 2020, 1:49 p.m. UTC
Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous prototype for ‘pl111_display_disable’ [-Wmissing-prototypes]

Cc: Eric Anholt <eric@anholt.net>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/gpu/drm/pl111/pl111_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sam Ravnborg Nov. 14, 2020, 7:11 p.m. UTC | #1
Hi Lee,
On Fri, Nov 13, 2020 at 01:49:10PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous prototype for ‘pl111_display_disable’ [-Wmissing-prototypes]
> 
> Cc: Eric Anholt <eric@anholt.net>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Eric's was not copied on this or the other pl111 patch.
Added Eric so he can be aware of this fix.

	Sam

> ---
>  drivers/gpu/drm/pl111/pl111_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
> index b3e8697cafcf1..69c02e7c82b7e 100644
> --- a/drivers/gpu/drm/pl111/pl111_display.c
> +++ b/drivers/gpu/drm/pl111/pl111_display.c
> @@ -353,7 +353,7 @@ static void pl111_display_enable(struct drm_simple_display_pipe *pipe,
>  		drm_crtc_vblank_on(crtc);
>  }
>  
> -void pl111_display_disable(struct drm_simple_display_pipe *pipe)
> +static void pl111_display_disable(struct drm_simple_display_pipe *pipe)
>  {
>  	struct drm_crtc *crtc = &pipe->crtc;
>  	struct drm_device *drm = crtc->dev;
> -- 
> 2.25.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Lee Jones Nov. 16, 2020, 8:40 a.m. UTC | #2
On Sat, 14 Nov 2020, Sam Ravnborg wrote:

> Hi Lee,
> On Fri, Nov 13, 2020 at 01:49:10PM +0000, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> > 
> >  drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous prototype for ‘pl111_display_disable’ [-Wmissing-prototypes]
> > 
> > Cc: Eric Anholt <eric@anholt.net>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: dri-devel@lists.freedesktop.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> 
> Eric's was not copied on this or the other pl111 patch.
> Added Eric so he can be aware of this fix.

Eric Anholt?

He's on Cc?

> > ---
> >  drivers/gpu/drm/pl111/pl111_display.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
> > index b3e8697cafcf1..69c02e7c82b7e 100644
> > --- a/drivers/gpu/drm/pl111/pl111_display.c
> > +++ b/drivers/gpu/drm/pl111/pl111_display.c
> > @@ -353,7 +353,7 @@ static void pl111_display_enable(struct drm_simple_display_pipe *pipe,
> >  		drm_crtc_vblank_on(crtc);
> >  }
> >  
> > -void pl111_display_disable(struct drm_simple_display_pipe *pipe)
> > +static void pl111_display_disable(struct drm_simple_display_pipe *pipe)
> >  {
> >  	struct drm_crtc *crtc = &pipe->crtc;
> >  	struct drm_device *drm = crtc->dev;
Sam Ravnborg Nov. 16, 2020, 10:17 a.m. UTC | #3
Hi Lee,
On Mon, Nov 16, 2020 at 08:40:23AM +0000, Lee Jones wrote:
> On Sat, 14 Nov 2020, Sam Ravnborg wrote:
> 
> > Hi Lee,
> > On Fri, Nov 13, 2020 at 01:49:10PM +0000, Lee Jones wrote:
> > > Fixes the following W=1 kernel build warning(s):
> > > 
> > >  drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous prototype for ‘pl111_display_disable’ [-Wmissing-prototypes]
> > > 
> > > Cc: Eric Anholt <eric@anholt.net>
> > > Cc: David Airlie <airlied@linux.ie>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Cc: dri-devel@lists.freedesktop.org
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > 
> > Eric's was not copied on this or the other pl111 patch.
> > Added Eric so he can be aware of this fix.
> 
> Eric Anholt?
> 
> He's on Cc?
Not on the original mail I received.

	Sam
Lee Jones Nov. 16, 2020, 10:25 a.m. UTC | #4
On Mon, 16 Nov 2020, Sam Ravnborg wrote:

> Hi Lee,
> On Mon, Nov 16, 2020 at 08:40:23AM +0000, Lee Jones wrote:
> > On Sat, 14 Nov 2020, Sam Ravnborg wrote:
> > 
> > > Hi Lee,
> > > On Fri, Nov 13, 2020 at 01:49:10PM +0000, Lee Jones wrote:
> > > > Fixes the following W=1 kernel build warning(s):
> > > > 
> > > >  drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous prototype for ‘pl111_display_disable’ [-Wmissing-prototypes]
> > > > 
> > > > Cc: Eric Anholt <eric@anholt.net>
> > > > Cc: David Airlie <airlied@linux.ie>
> > > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > > Cc: dri-devel@lists.freedesktop.org
> > > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > 
> > > Eric's was not copied on this or the other pl111 patch.
> > > Added Eric so he can be aware of this fix.
> > 
> > Eric Anholt?
> > 
> > He's on Cc?
> Not on the original mail I received.

Looks fine to me:

Date: Fri, 13 Nov 2020 13:49:10 +0000
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, Eric Anholt <eric@anholt.net>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, dri-devel@lists.freedesktop.org
Subject: [PATCH 12/40] drm/pl111/pl111_display: Make local function static

Also reflected in Gmail:

 https://i.imgur.com/d69YTzz.png
Sam Ravnborg Nov. 16, 2020, 11:18 a.m. UTC | #5
Hi Lee,
On Mon, Nov 16, 2020 at 10:25:30AM +0000, Lee Jones wrote:
> On Mon, 16 Nov 2020, Sam Ravnborg wrote:
> 
> > Hi Lee,
> > On Mon, Nov 16, 2020 at 08:40:23AM +0000, Lee Jones wrote:
> > > On Sat, 14 Nov 2020, Sam Ravnborg wrote:
> > > 
> > > > Hi Lee,
> > > > On Fri, Nov 13, 2020 at 01:49:10PM +0000, Lee Jones wrote:
> > > > > Fixes the following W=1 kernel build warning(s):
> > > > > 
> > > > >  drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous prototype for ‘pl111_display_disable’ [-Wmissing-prototypes]
> > > > > 
> > > > > Cc: Eric Anholt <eric@anholt.net>
> > > > > Cc: David Airlie <airlied@linux.ie>
> > > > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > > > Cc: dri-devel@lists.freedesktop.org
> > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > > 
> > > > Eric's was not copied on this or the other pl111 patch.
> > > > Added Eric so he can be aware of this fix.
> > > 
> > > Eric Anholt?
> > > 
> > > He's on Cc?
> > Not on the original mail I received.
> 
> Looks fine to me:
> 
> Date: Fri, 13 Nov 2020 13:49:10 +0000
> From: Lee Jones <lee.jones@linaro.org>
> To: lee.jones@linaro.org
> Cc: linux-kernel@vger.kernel.org, Eric Anholt <eric@anholt.net>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, dri-devel@lists.freedesktop.org
> Subject: [PATCH 12/40] drm/pl111/pl111_display: Make local function static
> 
> Also reflected in Gmail:
> 
>  https://i.imgur.com/d69YTzz.png

Strange indeed. In lore Eric is not included:
https://lore.kernel.org/dri-devel/20201113134938.4004947-13-lee.jones@linaro.org/

I consider this a fluke in the force, and will not worry more about it.

	Sam
diff mbox series

Patch

diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
index b3e8697cafcf1..69c02e7c82b7e 100644
--- a/drivers/gpu/drm/pl111/pl111_display.c
+++ b/drivers/gpu/drm/pl111/pl111_display.c
@@ -353,7 +353,7 @@  static void pl111_display_enable(struct drm_simple_display_pipe *pipe,
 		drm_crtc_vblank_on(crtc);
 }
 
-void pl111_display_disable(struct drm_simple_display_pipe *pipe)
+static void pl111_display_disable(struct drm_simple_display_pipe *pipe)
 {
 	struct drm_crtc *crtc = &pipe->crtc;
 	struct drm_device *drm = crtc->dev;