From patchwork Fri Nov 13 13:49:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11903433 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30DB6C388F7 for ; Fri, 13 Nov 2020 13:50:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5B3822249 for ; Fri, 13 Nov 2020 13:50:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N+zM6zcZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5B3822249 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B3A2B6E4EA; Fri, 13 Nov 2020 13:50:15 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id E1B2A6E4EC for ; Fri, 13 Nov 2020 13:50:02 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id 33so9980938wrl.7 for ; Fri, 13 Nov 2020 05:50:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z4Rt5MfpdBDV0pCvJqA/7OOspni5CCJQuMFleU8qAsI=; b=N+zM6zcZSVFZCdJrsj9mEKmy9LZp5xIJvVdJJOafLItXmWclcO1seEQot59X2vEN+w bSSFvnDESI+BXkh18u4frFboxNp/Zsh+WDRUEnVccULFIUmPkdRnIqGkBl8cWCRs7FZ0 NIZoh5uDPA5xR8R0TpAZDiJeGdaHeoOs6ny1ukNzxgV8YtJL7uaG0VJWfzf56e6qYWUc xuPAfqt3r5t9ltpEXF8RfhRyDn65i/O6VCpZmvQSiCxiLVanxYpfxCk7th1SV9qhR1mA 5vwX900qX5B5BGhC1qN/gvuOyJQnV/JkcIHm97z97SOCx/wejQBjzrUiLbQ93PyAjUIb WtSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z4Rt5MfpdBDV0pCvJqA/7OOspni5CCJQuMFleU8qAsI=; b=N60/7lhCKicV6K/sLocnqP6aFg2zvqkzdkpyeHvx3wkr7cBTNv+aHrucOIUQ0f7QVC eM3lD//XBIu/uIxNAjb295d45HMWew8rK+0Ty/iqpGZydZfUOeNYgrQhLRG8GMCmpz/0 Ie416mqM/qe1CDK18M2DyDZQstqBMuB3k6PoSW/Uoj0hHDI2XZz5W5o7Ei040xNcdl/s d+9IDW+eZ1B7GowqTVaKZ15JKuWE3TxYmH6KtSHdRwsDcCpuNo3vXWYuXW0y1aF+CrKt EVwNMM7P1ilB20k3oyN9btNFUKpIRQPtX7cyMPsjHvO2uP1IvuanwMZm748VlIr0k5XV DJ5A== X-Gm-Message-State: AOAM530JEjZYvGy5JPZgQWEfcsDmS6tMt3wFdqVFGHZgkLHQW0hZMCQS lQHKTxkvlTX+hnDYjrOYJTz0JA== X-Google-Smtp-Source: ABdhPJx0smt20aVTrHVG68Hi6o1SogLHhzsaE/8xGQk5oruEnBKEdMWr2G0xpdZpuag2G6RsfPRBoA== X-Received: by 2002:adf:ce87:: with SMTP id r7mr3568696wrn.212.1605275401516; Fri, 13 Nov 2020 05:50:01 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id t11sm4561614wrm.8.2020.11.13.05.50.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2020 05:50:00 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 16/40] drm/amd/amdgpu/amdgpu_sync: Fix misnamed, missing and extra param descriptions Date: Fri, 13 Nov 2020 13:49:14 +0000 Message-Id: <20201113134938.4004947-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201113134938.4004947-1-lee.jones@linaro.org> References: <20201113134938.4004947-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Felix Kuehling , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Chri?= =?utf-8?q?stian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c:86: warning: Function parameter or member 'f' not described in 'amdgpu_sync_get_owner' drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c:86: warning: Excess function parameter 'fence' description in 'amdgpu_sync_get_owner' drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c:182: warning: Excess function parameter 'adev' description in 'amdgpu_sync_vm_fence' drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c:203: warning: Function parameter or member 'adev' not described in 'amdgpu_sync_resv' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: Felix Kuehling Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c index 8ea6c49529e7d..4e558632a5d2b 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c @@ -78,7 +78,7 @@ static bool amdgpu_sync_same_dev(struct amdgpu_device *adev, /** * amdgpu_sync_get_owner - extract the owner of a fence * - * @fence: fence get the owner from + * @f: fence get the owner from * * Extract who originally created the fence. */ @@ -172,7 +172,6 @@ int amdgpu_sync_fence(struct amdgpu_sync *sync, struct dma_fence *f) /** * amdgpu_sync_vm_fence - remember to sync to this VM fence * - * @adev: amdgpu device * @sync: sync object to add fence to * @fence: the VM fence to add * @@ -190,6 +189,7 @@ int amdgpu_sync_vm_fence(struct amdgpu_sync *sync, struct dma_fence *fence) /** * amdgpu_sync_resv - sync to a reservation object * + * @adev: amdgpu device * @sync: sync object to add fences from reservation object to * @resv: reservation object with embedded fence * @mode: how owner affects which fences we sync to