From patchwork Fri Nov 13 13:49:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11903435 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02B3DC63697 for ; Fri, 13 Nov 2020 13:50:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B34F922240 for ; Fri, 13 Nov 2020 13:50:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ox7jf1lZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B34F922240 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A8FA56E526; Fri, 13 Nov 2020 13:50:16 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 25D9D6E4EA for ; Fri, 13 Nov 2020 13:50:15 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id b6so9993872wrt.4 for ; Fri, 13 Nov 2020 05:50:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BzoA0/p90w69kCv3e5Q2d2JhA6KtEucuiNdT/rFnC4I=; b=ox7jf1lZwfwZsOGGRxrgIuDFmMt/t3EA9CY44da6nxv97y3o6P6e3V3SK8STEuDHTx uieKR6jD3bQvVud1bFo69dW/kuNx60kde6emW4UAetcflcKaRTsuDtMcDWUlmxyaJwT9 wOuJ42ZmsGwUk5Cd9hwHMfR2knehgRRvTAfmqo2DDU33pgXSrhJGPEx40GUvbRPorBxG jAt3PWNRMXwOxUkY6KekxOtr8lyHSCT3eTVnL+MlKsbvcZDU4Zmn9ZRUCW01FI1S8fNc pFScRBfMNP9nq7H3qm4Zz/b7hlbWIg336mGnECdKl9XfzjDeWdTBlXyjqjYCZftHhCP/ ReoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BzoA0/p90w69kCv3e5Q2d2JhA6KtEucuiNdT/rFnC4I=; b=AoCzKWanfILwVzGl93KY1RyAk6JbgxAp0wYJ/PxlU/ceXv0UrpFCjgcIbNCAx0L8vL HKqkcxHInMbCLAoAnCKzjYkPU5E6uIdvwWv+fJNDzgx3k45QwdErpRICMRJHfLpzR1bb lT6TJKYWpt+cIi4/iB3KztTSzbJbLR2/e3HYf8eT6+WVOwi5o6p5u7FE27X9Le7zNJpy tTOisOxEIy0yjX0dLwfdvDUY4SNAaek/GGyVWKEWM2OI39ToDIqeI177xox26/pvPdVA 5UYRIY93NzQHfgufquOMaoDqji1uQ7ZVMFVW9TDXznQ6ajPwOKTBj4Uo7bXZgPstZfBN nWPg== X-Gm-Message-State: AOAM531J3FnYzUj02wJcTnzqZ8mN4u2Kahv2cgnGqGsXlKgIYBeT+tOW ZDRcT0yxJFpt8L2VbJECK3FcPg== X-Google-Smtp-Source: ABdhPJyM0RmlKSiadoyRmHxlgxkTDo9JK/uvB3fY0ok0WHJM9+gvf3MjB4rxoAncUj/U16DHjVwYaQ== X-Received: by 2002:a5d:5752:: with SMTP id q18mr3531340wrw.176.1605275413797; Fri, 13 Nov 2020 05:50:13 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id t11sm4561614wrm.8.2020.11.13.05.50.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2020 05:50:13 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 26/40] drm/amd/amdgpu/amdgpu_gmc: Demote one and fix another function header Date: Fri, 13 Nov 2020 13:49:24 +0000 Message-Id: <20201113134938.4004947-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201113134938.4004947-1-lee.jones@linaro.org> References: <20201113134938.4004947-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:69: warning: Function parameter or member 'bo' not described in 'amdgpu_gmc_pd_addr' drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:121: warning: Function parameter or member 'bo' not described in 'amdgpu_gmc_agp_addr' drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:121: warning: Excess function parameter 'tbo' description in 'amdgpu_gmc_agp_addr' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c index 056cb87d09ea3..fede84509dbca 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c @@ -61,9 +61,8 @@ void amdgpu_gmc_get_pde_for_bo(struct amdgpu_bo *bo, int level, amdgpu_gmc_get_vm_pde(adev, level, addr, flags); } -/** +/* * amdgpu_gmc_pd_addr - return the address of the root directory - * */ uint64_t amdgpu_gmc_pd_addr(struct amdgpu_bo *bo) { @@ -112,7 +111,7 @@ int amdgpu_gmc_set_pte_pde(struct amdgpu_device *adev, void *cpu_pt_addr, /** * amdgpu_gmc_agp_addr - return the address in the AGP address space * - * @tbo: TTM BO which needs the address, must be in GTT domain + * @bo: TTM BO which needs the address, must be in GTT domain * * Tries to figure out how to access the BO through the AGP aperture. Returns * AMDGPU_BO_INVALID_OFFSET if that is not possible.