From patchwork Mon Nov 23 11:18:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11924885 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E261AC2D0E4 for ; Mon, 23 Nov 2020 11:19:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83A8A2065E for ; Mon, 23 Nov 2020 11:19:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tyD96b5E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83A8A2065E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EFF3789A9A; Mon, 23 Nov 2020 11:19:41 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id E9F06897FB for ; Mon, 23 Nov 2020 11:19:31 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id 64so4789312wra.11 for ; Mon, 23 Nov 2020 03:19:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=92lYcVhCJmrBtBX57wzHE1WdwDpEBe0J2p2RduAzKmY=; b=tyD96b5E1MNVsARdONjKjj8lmiQOPG6HZ3J3yYA1X4O8NytzLWdgQ3BBX81GdNztUl MCz53tT3e5DvsGOFVHSrLS+yMgZJbL9BqRG7mblwgYdUSS6grX3F6O5StAdtIkZDKP8g he1etgev1uTEcr+qss2qE0ldGmea0gH2u3G5JwBLWNf8NXLw/tJ/8nP63Rji6V42Ddv0 CTgUcts+FDVic+ESjPSXDj3UbnTuc4NRq5pR/45zmFx0tu3zVBH8WqlUSSLD1qlhvd/F 78H+/sQ+C4P4NLchyX10tlytKAgUWja4o7e6KZTTF83WvHiKFSBFIoyKHqSvRTD/dNuv 2dBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=92lYcVhCJmrBtBX57wzHE1WdwDpEBe0J2p2RduAzKmY=; b=kDt9euHdsRwHyty5DLSlKbAn73gGe2kOcSzGIc4wPGTOJS0vA8KW4yw/9xJxYiznvT O35xUj1WH8UMq9tGh5Er0iayKIQvbDM+1cAcu7dU5ynN2JrUwsgWW27vSSYaSuMdB8I6 f6wCaY7nzkUsZmIiLHttm6HCJf5RSwnk66Ez+aKyZqFOEfn3+SRIsgNFUDKq0csw729k leDC8fzL/CmioIzetW+d9ps7f4AHwNhzujQcrdy1b0JUu+mgve2QDYAA2H4xT9uAPOvM v6iwUz3xMw2nttr7d3NPnsEv2Ml0gOAbVGCprkeMkc/QkEjrvmc0XNDBvQYMmjv+jZ2X Xw2Q== X-Gm-Message-State: AOAM533Yt7EBpaYy5prEASQmS9Pplg+Vv3ZWdRHMy2OoeJ3YMwht0/J4 aluAqPXKRbFKFkWWqEjuYCNdBg== X-Google-Smtp-Source: ABdhPJxcFX2r+8zpTqB0xgdePYGFbP22M8rI4oqeupSBv1b98mkYBBpmFJ5H9NVGiGoalECnVCPurg== X-Received: by 2002:adf:e3c9:: with SMTP id k9mr30883095wrm.275.1606130370615; Mon, 23 Nov 2020 03:19:30 -0800 (PST) Received: from dell.default ([91.110.221.218]) by smtp.gmail.com with ESMTPSA id n9sm16317290wmd.4.2020.11.23.03.19.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 03:19:29 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 06/40] drm/amd/amdgpu/uvd_v4_2: Fix some kernel-doc misdemeanours Date: Mon, 23 Nov 2020 11:18:45 +0000 Message-Id: <20201123111919.233376-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201123111919.233376-1-lee.jones@linaro.org> References: <20201123111919.233376-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c:157: warning: Function parameter or member 'handle' not described in 'uvd_v4_2_hw_init' drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c:157: warning: Excess function parameter 'adev' description in 'uvd_v4_2_hw_init' drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c:212: warning: Function parameter or member 'handle' not described in 'uvd_v4_2_hw_fini' drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c:212: warning: Excess function parameter 'adev' description in 'uvd_v4_2_hw_fini' drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c:446: warning: Function parameter or member 'addr' not described in 'uvd_v4_2_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c:446: warning: Function parameter or member 'seq' not described in 'uvd_v4_2_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c:446: warning: Function parameter or member 'flags' not described in 'uvd_v4_2_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c:446: warning: Excess function parameter 'fence' description in 'uvd_v4_2_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c:513: warning: Function parameter or member 'job' not described in 'uvd_v4_2_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c:513: warning: Function parameter or member 'flags' not described in 'uvd_v4_2_ring_emit_ib' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c b/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c index b0c0c438fc93c..2c8c35c3bca52 100644 --- a/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c @@ -149,7 +149,7 @@ static void uvd_v4_2_enable_mgcg(struct amdgpu_device *adev, /** * uvd_v4_2_hw_init - start and test UVD block * - * @adev: amdgpu_device pointer + * @handle: handle used to pass amdgpu_device pointer * * Initialize the hardware, boot up the VCPU and do some testing */ @@ -204,7 +204,7 @@ static int uvd_v4_2_hw_init(void *handle) /** * uvd_v4_2_hw_fini - stop the hardware block * - * @adev: amdgpu_device pointer + * @handle: handle used to pass amdgpu_device pointer * * Stop the UVD block, mark ring as not ready any more */ @@ -437,6 +437,8 @@ static void uvd_v4_2_stop(struct amdgpu_device *adev) * uvd_v4_2_ring_emit_fence - emit an fence & trap command * * @ring: amdgpu_ring pointer + * @addr: address + * @seq: sequence number * @fence: fence to emit * * Write a fence and a trap command to the ring. @@ -502,7 +504,9 @@ static int uvd_v4_2_ring_test_ring(struct amdgpu_ring *ring) * uvd_v4_2_ring_emit_ib - execute indirect buffer * * @ring: amdgpu_ring pointer + * @job: unused * @ib: indirect buffer to execute + * @flags: unused * * Write ring commands to execute the indirect buffer */