| Message ID | 20201124124538.660710-64-tomi.valkeinen@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Convert DSI code to use drm_mipi_dsi and drm_panel | expand |
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:21PM +0200, Tomi Valkeinen wrote: > A DSI peripheral can have virtual channel ID of 0-3. This should be > always the case, and there's no need in the driver to validate the > channel. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index 63338324c564..fbf05097612f 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -3902,9 +3902,6 @@ static int dsi_update_channel(struct omap_dss_device *dssdev, int channel) > struct dsi_data *dsi = to_dsi_data(dssdev); > int r; > > - if (channel > 3) > - return -EINVAL; > - > dsi_bus_lock(dsi); > > if (!dsi->video_enabled) { > @@ -5063,12 +5060,8 @@ static int omap_dsi_host_attach(struct mipi_dsi_host *host, > struct mipi_dsi_device *client) > { > struct dsi_data *dsi = host_to_omap(host); > - unsigned int channel = client->channel; > int r; > > - if (channel > 3) > - return -EINVAL; > - > if (dsi->dsidev) { > DSSERR("dsi client already attached\n"); > return -EBUSY; > @@ -5118,10 +5111,6 @@ static int omap_dsi_host_detach(struct mipi_dsi_host *host, > struct mipi_dsi_device *client) > { > struct dsi_data *dsi = host_to_omap(host); > - unsigned int channel = client->channel; > - > - if (channel > 3) > - return -EINVAL; > > if (WARN_ON(dsi->dsidev != client)) > return -EINVAL;
diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index 63338324c564..fbf05097612f 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c @@ -3902,9 +3902,6 @@ static int dsi_update_channel(struct omap_dss_device *dssdev, int channel) struct dsi_data *dsi = to_dsi_data(dssdev); int r; - if (channel > 3) - return -EINVAL; - dsi_bus_lock(dsi); if (!dsi->video_enabled) { @@ -5063,12 +5060,8 @@ static int omap_dsi_host_attach(struct mipi_dsi_host *host, struct mipi_dsi_device *client) { struct dsi_data *dsi = host_to_omap(host); - unsigned int channel = client->channel; int r; - if (channel > 3) - return -EINVAL; - if (dsi->dsidev) { DSSERR("dsi client already attached\n"); return -EBUSY; @@ -5118,10 +5111,6 @@ static int omap_dsi_host_detach(struct mipi_dsi_host *host, struct mipi_dsi_device *client) { struct dsi_data *dsi = host_to_omap(host); - unsigned int channel = client->channel; - - if (channel > 3) - return -EINVAL; if (WARN_ON(dsi->dsidev != client)) return -EINVAL;
A DSI peripheral can have virtual channel ID of 0-3. This should be always the case, and there's no need in the driver to validate the channel. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> --- drivers/gpu/drm/omapdrm/dss/dsi.c | 11 ----------- 1 file changed, 11 deletions(-)