From patchwork Fri Nov 27 19:58:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11937155 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABB97C5519F for ; Fri, 27 Nov 2020 19:58:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A7FA208D5 for ; Fri, 27 Nov 2020 19:58:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jQJJ5C2S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A7FA208D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7B56F6F3C2; Fri, 27 Nov 2020 19:58:49 +0000 (UTC) Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 284DB6F3B5 for ; Fri, 27 Nov 2020 19:58:46 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id l11so8587919lfg.0 for ; Fri, 27 Nov 2020 11:58:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=elXwDkZqCWbwars/a4PGxe80QnxYqSvOiXbjb845R9M=; b=jQJJ5C2S7D8szVUR25mbQT5RmCZpktF7FWL3p0OS57iRBuna6+UiSzqrn5Pv3gOO5A 2oILbhokAeBdbYfI3Zw+b1ya+RZ8KfyrTKG2dlmHl14lPej6x8/ZHQAEmXnhZDd9XI2b mjTFmyM/x5arLTXOpOJPImA/G99hdnc3fEderAiqRBNil5gdBOfzZ1UFUglTGLe8pBKV E7IUwNmbMUh0hVJWdqbomvCxozev0ljukOfKl2EdMhenNN7hnv83Pj/c3/qHSE2cATIu UuJbfK+LNozQUhL3a7jVRGNqgDpXbw8QBT6qEagMw51lQHDQMkERakZHJNbCWEO8moOi /Eng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=elXwDkZqCWbwars/a4PGxe80QnxYqSvOiXbjb845R9M=; b=KMIw/AwZTPsh5fxmWmLVBeQSD9Ydfimc2lQJm2RilUDNnLTjX47tTTG7ush9fBgqIn +YZDUwU+31eIlemcVntA5zGmseeTvsvlIyv/2RJ85A3ubzegtD9u+F609uWUsT9UnrzM syAzFbbrxEmNhA4tHseIZyMIrYcIcw5RdGWwUFYCzPtIxRZuGNnP9SF+mYES7bhR0UYJ DnfTxAKTFBKwoalFHDQS9vbk1fwCEt03D6jbHcMxg4Ka1/6kmPatRHeuoUL587Lq/L+x NEll4R4sRikL/wyO50FvjxoSaubOAnvMG6JxQJbvH74GeYjCPrAUmrVQaAS9luHiKvmx /tqQ== X-Gm-Message-State: AOAM533KzIvFnLq1aGjzaFEWePsSkqIb8i5gTJjOLmCukAosZWeugO9e K90ybrFUxJKx/L3wcRKdOKY= X-Google-Smtp-Source: ABdhPJyEvODl2X9feO2V1e8aOwadRfjN8fIygmoqxMNyeCNcXtYuBfiDpc2mv8qb3JKasYlmoB391A== X-Received: by 2002:ac2:4559:: with SMTP id j25mr2183950lfm.511.1606507124592; Fri, 27 Nov 2020 11:58:44 -0800 (PST) Received: from saturn.localdomain ([2a00:fd00:8060:1c00:9d62:990:4557:451]) by smtp.gmail.com with ESMTPSA id c6sm1070415ljj.140.2020.11.27.11.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 11:58:44 -0800 (PST) From: Sam Ravnborg To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Subject: [PATCH v1 04/28] video: fbdev: aty: Delete unused variable in radeon_monitor Date: Fri, 27 Nov 2020 20:58:01 +0100 Message-Id: <20201127195825.858960-5-sam@ravnborg.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201127195825.858960-1-sam@ravnborg.org> References: <20201127195825.858960-1-sam@ravnborg.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vaibhav Gupta , Tetsuo Handa , Peter Rosin , Michal Januszewski , Laurent Pinchart , linux-nvidia@lists.surfsouth.com, Jiri Slaby , Arnd Bergmann , Florian Tobias Schandinat , Evgeny Novikov , Sam Ravnborg , Saeed Mirzamohammadi , Daniel Vetter , Thomas Winischhofer , Thomas Zimemrmann , Bartlomiej Zolnierkiewicz , Jani Nikula , Aditya Pakki , Xiaofei Tan , Nathan Chancellor , Alex Dewar , Jason Yan , Greg Kroah-Hartman , Qilong Zhang , Randy Dunlap , Gustavo Silva , Ferenc Bakonyi , George Kennedy , Kristoffer Ericson , Alexander Klimov , Jingoo Han , Joe Perches , Peilin Ye , Mike Rapoport Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fix W=1 about variable that is asssigned a value but never used. The variable was indeed never used so delete it. Keep the call to radeon_probe_i2c_connector() as it may have side-effects. It is unlikely but I could not verify that is was safe to drop the call. Signed-off-by: Sam Ravnborg Cc: Benjamin Herrenschmidt Cc: linux-fbdev@vger.kernel.org --- drivers/video/fbdev/aty/radeon_monitor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/aty/radeon_monitor.c b/drivers/video/fbdev/aty/radeon_monitor.c index 9966c58aa26c..df55e23b7a5a 100644 --- a/drivers/video/fbdev/aty/radeon_monitor.c +++ b/drivers/video/fbdev/aty/radeon_monitor.c @@ -488,12 +488,10 @@ void radeon_probe_screens(struct radeonfb_info *rinfo, #if defined(DEBUG) && defined(CONFIG_FB_RADEON_I2C) { u8 *EDIDs[4] = { NULL, NULL, NULL, NULL }; - int mon_types[4] = {MT_NONE, MT_NONE, MT_NONE, MT_NONE}; int i; for (i = 0; i < 4; i++) - mon_types[i] = radeon_probe_i2c_connector(rinfo, - i+1, &EDIDs[i]); + radeon_probe_i2c_connector(rinfo, i + 1, &EDIDs[i]); } #endif /* DEBUG */ /*