diff mbox series

[v2,11/28] video: fbdev: via: Fix set but not used warning for mode_crt_table

Message ID 20201128224114.1033617-12-sam@ravnborg.org (mailing list archive)
State New, archived
Headers show
Series drivers/video: W=1 warning fixes | expand

Commit Message

Sam Ravnborg Nov. 28, 2020, 10:40 p.m. UTC
Fix warning by deleting the variable. The function call
viafb_get_best_mode() were verified to have no side-effects,
and thus could be dropped too.

v2:
  - Update subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: linux-fbdev@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/video/fbdev/via/lcd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Thomas Zimmermann Nov. 30, 2020, 12:08 p.m. UTC | #1
Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
> Fix warning by deleting the variable. The function call
> viafb_get_best_mode() were verified to have no side-effects,

s/were/was

> and thus could be dropped too.
> 
> v2:
>    - Update subject (Lee)
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
> Cc: linux-fbdev@vger.kernel.org
> Cc: Lee Jones <lee.jones@linaro.org>

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   drivers/video/fbdev/via/lcd.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/video/fbdev/via/lcd.c b/drivers/video/fbdev/via/lcd.c
> index 4a869402d120..088b962076b5 100644
> --- a/drivers/video/fbdev/via/lcd.c
> +++ b/drivers/video/fbdev/via/lcd.c
> @@ -537,11 +537,9 @@ void viafb_lcd_set_mode(const struct fb_var_screeninfo *var, u16 cxres,
>   	u32 clock;
>   	struct via_display_timing timing;
>   	struct fb_var_screeninfo panel_var;
> -	const struct fb_videomode *mode_crt_table, *panel_crt_table;
> +	const struct fb_videomode *panel_crt_table;
>   
>   	DEBUG_MSG(KERN_INFO "viafb_lcd_set_mode!!\n");
> -	/* Get mode table */
> -	mode_crt_table = viafb_get_best_mode(set_hres, set_vres, 60);
>   	/* Get panel table Pointer */
>   	panel_crt_table = viafb_get_best_mode(panel_hres, panel_vres, 60);
>   	viafb_fill_var_timing_info(&panel_var, panel_crt_table);
>
diff mbox series

Patch

diff --git a/drivers/video/fbdev/via/lcd.c b/drivers/video/fbdev/via/lcd.c
index 4a869402d120..088b962076b5 100644
--- a/drivers/video/fbdev/via/lcd.c
+++ b/drivers/video/fbdev/via/lcd.c
@@ -537,11 +537,9 @@  void viafb_lcd_set_mode(const struct fb_var_screeninfo *var, u16 cxres,
 	u32 clock;
 	struct via_display_timing timing;
 	struct fb_var_screeninfo panel_var;
-	const struct fb_videomode *mode_crt_table, *panel_crt_table;
+	const struct fb_videomode *panel_crt_table;
 
 	DEBUG_MSG(KERN_INFO "viafb_lcd_set_mode!!\n");
-	/* Get mode table */
-	mode_crt_table = viafb_get_best_mode(set_hres, set_vres, 60);
 	/* Get panel table Pointer */
 	panel_crt_table = viafb_get_best_mode(panel_hres, panel_vres, 60);
 	viafb_fill_var_timing_info(&panel_var, panel_crt_table);