diff mbox series

[v2,04/28] video: fbdev: aty: Delete unused variable in radeon_monitor

Message ID 20201128224114.1033617-5-sam@ravnborg.org (mailing list archive)
State New, archived
Headers show
Series drivers/video: W=1 warning fixes | expand

Commit Message

Sam Ravnborg Nov. 28, 2020, 10:40 p.m. UTC
Fix warning about variable that is asssigned a value but never used.
The variable was indeed never used so delete it.

Keep the call to radeon_probe_i2c_connector() as it may have
side-effects. It is unlikely but I could not verify that is was safe to
drop the call.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-fbdev@vger.kernel.org
---
 drivers/video/fbdev/aty/radeon_monitor.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Thomas Zimmermann Nov. 30, 2020, 8:51 a.m. UTC | #1
Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
> Fix warning about variable that is asssigned a value but never used.
> The variable was indeed never used so delete it.
> 
> Keep the call to radeon_probe_i2c_connector() as it may have
> side-effects. It is unlikely but I could not verify that is was safe to
> drop the call.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: linux-fbdev@vger.kernel.org

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   drivers/video/fbdev/aty/radeon_monitor.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/video/fbdev/aty/radeon_monitor.c b/drivers/video/fbdev/aty/radeon_monitor.c
> index 9966c58aa26c..df55e23b7a5a 100644
> --- a/drivers/video/fbdev/aty/radeon_monitor.c
> +++ b/drivers/video/fbdev/aty/radeon_monitor.c
> @@ -488,12 +488,10 @@ void radeon_probe_screens(struct radeonfb_info *rinfo,
>   #if defined(DEBUG) && defined(CONFIG_FB_RADEON_I2C)
>   		{
>   			u8 *EDIDs[4] = { NULL, NULL, NULL, NULL };
> -			int mon_types[4] = {MT_NONE, MT_NONE, MT_NONE, MT_NONE};
>   			int i;
>   
>   			for (i = 0; i < 4; i++)
> -				mon_types[i] = radeon_probe_i2c_connector(rinfo,
> -									  i+1, &EDIDs[i]);
> +				radeon_probe_i2c_connector(rinfo, i + 1, &EDIDs[i]);
>   		}
>   #endif /* DEBUG */
>   		/*
>
diff mbox series

Patch

diff --git a/drivers/video/fbdev/aty/radeon_monitor.c b/drivers/video/fbdev/aty/radeon_monitor.c
index 9966c58aa26c..df55e23b7a5a 100644
--- a/drivers/video/fbdev/aty/radeon_monitor.c
+++ b/drivers/video/fbdev/aty/radeon_monitor.c
@@ -488,12 +488,10 @@  void radeon_probe_screens(struct radeonfb_info *rinfo,
 #if defined(DEBUG) && defined(CONFIG_FB_RADEON_I2C)
 		{
 			u8 *EDIDs[4] = { NULL, NULL, NULL, NULL };
-			int mon_types[4] = {MT_NONE, MT_NONE, MT_NONE, MT_NONE};
 			int i;
 
 			for (i = 0; i < 4; i++)
-				mon_types[i] = radeon_probe_i2c_connector(rinfo,
-									  i+1, &EDIDs[i]);
+				radeon_probe_i2c_connector(rinfo, i + 1, &EDIDs[i]);
 		}
 #endif /* DEBUG */
 		/*