diff mbox series

[v6,2/8] dt-bindings: display: simple: add EDT compatibles already supported by the driver

Message ID 20201202081826.29512-3-o.rempel@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series mainline Plymovent M2M and BAS board | expand

Commit Message

Oleksij Rempel Dec. 2, 2020, 8:18 a.m. UTC
Some EDT compatibles are already supported by the driver but will fail
on checkpatch script. Fix it by syncing dt-bindings documentation with the
driver.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 .../devicetree/bindings/display/panel/panel-simple.yaml        | 3 +++
 1 file changed, 3 insertions(+)

Comments

Sam Ravnborg Dec. 5, 2020, 7:35 p.m. UTC | #1
Hi Oleksij,

On Wed, Dec 02, 2020 at 09:18:20AM +0100, Oleksij Rempel wrote:
> Some EDT compatibles are already supported by the driver but will fail
> on checkpatch script. Fix it by syncing dt-bindings documentation with the
> driver.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  .../devicetree/bindings/display/panel/panel-simple.yaml        | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 428b03342fea..0bb3e67fb58c 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -108,10 +108,12 @@ properties:
>          # Emerging Display Technology Corp. 480x272 TFT Display with capacitive touch
>        - edt,et057090dhu
>          # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> +      - edt,et070080dh6
>        - edt,etm043080dh6gp
>          # Emerging Display Technology Corp. 480x272 TFT Display
>        - edt,etm0430g0dh6
>          # Emerging Display Technology Corp. 5.7" VGA TFT LCD panel
> +      - edt,etm0700g0bdh6
>        - edt,etm070080bdh6
The order is wrong here. edt,etm070080bdh6 comes before edt,etm0700g0bdh6.
I checked with "sort" in my editor just to make sure.

>          # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
>          # Same display as the ETM0700G0BDH6, but with changed hardware for the
> @@ -124,6 +126,7 @@ properties:
>        - edt,etm0700g0dh6
>          # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
>          # Same as ETM0700G0DH6 but with inverted pixel clock.
> +      - edt,etm0700g0edh6
>        - evervision,vgg804821
>          # Foxlink Group 5" WVGA TFT LCD panel
>        - foxlink,fl500wvr00-a0t

	Sam
Oleksij Rempel Dec. 7, 2020, 11:07 a.m. UTC | #2
On Sat, Dec 05, 2020 at 08:35:38PM +0100, Sam Ravnborg wrote:
> Hi Oleksij,
> 
> On Wed, Dec 02, 2020 at 09:18:20AM +0100, Oleksij Rempel wrote:
> > Some EDT compatibles are already supported by the driver but will fail
> > on checkpatch script. Fix it by syncing dt-bindings documentation with the
> > driver.
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> >  .../devicetree/bindings/display/panel/panel-simple.yaml        | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > index 428b03342fea..0bb3e67fb58c 100644
> > --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > @@ -108,10 +108,12 @@ properties:
> >          # Emerging Display Technology Corp. 480x272 TFT Display with capacitive touch
> >        - edt,et057090dhu
> >          # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> > +      - edt,et070080dh6
> >        - edt,etm043080dh6gp
> >          # Emerging Display Technology Corp. 480x272 TFT Display
> >        - edt,etm0430g0dh6
> >          # Emerging Display Technology Corp. 5.7" VGA TFT LCD panel
> > +      - edt,etm0700g0bdh6
> >        - edt,etm070080bdh6
> The order is wrong here. edt,etm070080bdh6 comes before edt,etm0700g0bdh6.
> I checked with "sort" in my editor just to make sure.

I would really like to remove this useless comments. It make sorting so
mach easier.

> >          # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> >          # Same display as the ETM0700G0BDH6, but with changed hardware for the
> > @@ -124,6 +126,7 @@ properties:
> >        - edt,etm0700g0dh6
> >          # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> >          # Same as ETM0700G0DH6 but with inverted pixel clock.
> > +      - edt,etm0700g0edh6
> >        - evervision,vgg804821
> >          # Foxlink Group 5" WVGA TFT LCD panel
> >        - foxlink,fl500wvr00-a0t
> 
> 	Sam
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 428b03342fea..0bb3e67fb58c 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -108,10 +108,12 @@  properties:
         # Emerging Display Technology Corp. 480x272 TFT Display with capacitive touch
       - edt,et057090dhu
         # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
+      - edt,et070080dh6
       - edt,etm043080dh6gp
         # Emerging Display Technology Corp. 480x272 TFT Display
       - edt,etm0430g0dh6
         # Emerging Display Technology Corp. 5.7" VGA TFT LCD panel
+      - edt,etm0700g0bdh6
       - edt,etm070080bdh6
         # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
         # Same display as the ETM0700G0BDH6, but with changed hardware for the
@@ -124,6 +126,7 @@  properties:
       - edt,etm0700g0dh6
         # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
         # Same as ETM0700G0DH6 but with inverted pixel clock.
+      - edt,etm0700g0edh6
       - evervision,vgg804821
         # Foxlink Group 5" WVGA TFT LCD panel
       - foxlink,fl500wvr00-a0t