Message ID | 20201230152944.3635488-1-iskren.chernev@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [1/2] drm/msm: Call msm_init_vram before binding the gpu | expand |
Tested these patches on Samsung Galaxy S5 along with other patches that add panel driver and enable GPU support on this device. Tested-by: Alexey Minnekhanov <alexeymin@postmarketos.org> On 12/30/20 6:29 PM, Iskren Chernev wrote: > From: Craig Tatlor <ctatlor97@gmail.com> > > vram.size is needed when binding a gpu without an iommu and is defined > in msm_init_vram(), so run that before binding it. > > Signed-off-by: Craig Tatlor <ctatlor97@gmail.com> > --- > drivers/gpu/drm/msm/msm_drv.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 535a0263ceeb4..108c405e03dd9 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -457,14 +457,14 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv) drm_mode_config_init(ddev); - /* Bind all our sub-components: */ - ret = component_bind_all(dev, ddev); + ret = msm_init_vram(ddev); if (ret) goto err_destroy_mdss; - ret = msm_init_vram(ddev); + /* Bind all our sub-components: */ + ret = component_bind_all(dev, ddev); if (ret) - goto err_msm_uninit; + goto err_destroy_mdss; dma_set_max_seg_size(dev, UINT_MAX);