| Message ID | 20210107162632.v7.3.I3af068abe30c9c85cabc4486385c52e56527a509@changeid (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panfrost: Add support for mt8183 GPU | expand |
On 1/7/21 9:26 AM, Nicolas Boichat wrote: > GPUs with more than a single regulator (e.g. G72 on MT8183) will > require platform-specific handling, disable devfreq for now. > > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> > --- > > Changes in v7: > - Fix GPU ID in commit message > > Changes in v6: > - New change > > drivers/gpu/drm/panfrost/panfrost_devfreq.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c > index f44d28fad085..1f49043aae73 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c > +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c > @@ -92,6 +92,15 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev) > struct thermal_cooling_device *cooling; > struct panfrost_devfreq *pfdevfreq = &pfdev->pfdevfreq; > > + if (pfdev->comp->num_supplies > 1) { > + /* > + * GPUs with more than 1 supply require platform-specific handling: > + * continue without devfreq > + */ > + DRM_DEV_ERROR(dev, "More than 1 supply is not supported yet\n"); Should this be info instead? Regards, Tomeu > + return 0; > + } > + > opp_table = dev_pm_opp_set_regulators(dev, pfdev->comp->supply_names, > pfdev->comp->num_supplies); > if (IS_ERR(opp_table)) { >
On Thu, Jan 7, 2021 at 4:31 PM Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote: > > On 1/7/21 9:26 AM, Nicolas Boichat wrote: > > GPUs with more than a single regulator (e.g. G72 on MT8183) will > > require platform-specific handling, disable devfreq for now. > > > > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> > > --- > > > > Changes in v7: > > - Fix GPU ID in commit message > > > > Changes in v6: > > - New change > > > > drivers/gpu/drm/panfrost/panfrost_devfreq.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c > > index f44d28fad085..1f49043aae73 100644 > > --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c > > +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c > > @@ -92,6 +92,15 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev) > > struct thermal_cooling_device *cooling; > > struct panfrost_devfreq *pfdevfreq = &pfdev->pfdevfreq; > > > > + if (pfdev->comp->num_supplies > 1) { > > + /* > > + * GPUs with more than 1 supply require platform-specific handling: > > + * continue without devfreq > > + */ > > + DRM_DEV_ERROR(dev, "More than 1 supply is not supported yet\n"); > > Should this be info instead? Sure, will fix in v8. > > Regards, > > Tomeu > > > + return 0; > > + } > > + > > opp_table = dev_pm_opp_set_regulators(dev, pfdev->comp->supply_names, > > pfdev->comp->num_supplies); > > if (IS_ERR(opp_table)) { > >
On 1/7/21 9:49 AM, Nicolas Boichat wrote: > On Thu, Jan 7, 2021 at 4:31 PM Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote: >> >> On 1/7/21 9:26 AM, Nicolas Boichat wrote: >>> GPUs with more than a single regulator (e.g. G72 on MT8183) will >>> require platform-specific handling, disable devfreq for now. >>> >>> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> >>> --- >>> >>> Changes in v7: >>> - Fix GPU ID in commit message >>> >>> Changes in v6: >>> - New change >>> >>> drivers/gpu/drm/panfrost/panfrost_devfreq.c | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c >>> index f44d28fad085..1f49043aae73 100644 >>> --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c >>> +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c >>> @@ -92,6 +92,15 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev) >>> struct thermal_cooling_device *cooling; >>> struct panfrost_devfreq *pfdevfreq = &pfdev->pfdevfreq; >>> >>> + if (pfdev->comp->num_supplies > 1) { >>> + /* >>> + * GPUs with more than 1 supply require platform-specific handling: >>> + * continue without devfreq >>> + */ >>> + DRM_DEV_ERROR(dev, "More than 1 supply is not supported yet\n"); >> >> Should this be info instead? > > Sure, will fix in v8. Thanks. With that change, patches 3 and 4 are R-b. Thanks again! Tomeu >> >> Regards, >> >> Tomeu >> >>> + return 0; >>> + } >>> + >>> opp_table = dev_pm_opp_set_regulators(dev, pfdev->comp->supply_names, >>> pfdev->comp->num_supplies); >>> if (IS_ERR(opp_table)) { >>>
diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c index f44d28fad085..1f49043aae73 100644 --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c @@ -92,6 +92,15 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev) struct thermal_cooling_device *cooling; struct panfrost_devfreq *pfdevfreq = &pfdev->pfdevfreq; + if (pfdev->comp->num_supplies > 1) { + /* + * GPUs with more than 1 supply require platform-specific handling: + * continue without devfreq + */ + DRM_DEV_ERROR(dev, "More than 1 supply is not supported yet\n"); + return 0; + } + opp_table = dev_pm_opp_set_regulators(dev, pfdev->comp->supply_names, pfdev->comp->num_supplies); if (IS_ERR(opp_table)) {
GPUs with more than a single regulator (e.g. G72 on MT8183) will require platform-specific handling, disable devfreq for now. Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> --- Changes in v7: - Fix GPU ID in commit message Changes in v6: - New change drivers/gpu/drm/panfrost/panfrost_devfreq.c | 9 +++++++++ 1 file changed, 9 insertions(+)